Automated Drupal 11 compatibility fixes for default_content

This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request is also openend and updated.

It is important that any automated tests available are run and that you manually test the changes.

Drupal 11 Compatibility

According to the Upgrade Status module → , even with these changes, this module is not yet compatible with Drupal 11.

Currently Drupal Rector, version 0.20.0, cannot fix all Drupal 11 compatibility problems.

Therefore these changes did not update the info.yml file for Drupal 11 compatibility.

Leaving this issue open, even after committing the current patch, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

Debug info

This patch was created using these packages:

1. drupal/upgrade_status: 4.1.0
2. mglaman/phpstan-drupal: 1.2.7
3. palantirnet/drupal-rector: 0.20.0

This comment was forced and has ignored the check if a change was already posted. This is only done when we want to update the issue without waiting for changes to happen.

This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

It is important that any automated tests available are run and that you manually test the changes.

Drupal 11 Compatibility

According to the Upgrade Status module → , even with these changes, this module is not yet compatible with Drupal 11.

Currently Drupal Rector, version 0.20.1, cannot fix all Drupal 11 compatibility problems.

Therefore, these changes did not update the info.yml file for Drupal 11 compatibility.

The compatibility issues that Upgrade Status found after the Drupal Rector fixes were applied are attached to help you resolve them manually.

Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

Debug information

These packages were used to generate the fixes:

1. drupal/upgrade_status: 4.1.0
2. mglaman/phpstan-drupal: 1.2.10
3. palantirnet/drupal-rector: 0.20.1

@mishradeepak1991 - I verified MR 46 and can see following deprecations hence needs work.

modules/contrib/default_content/tests/src/Kernel/ExporterIntegrationTest.php

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Fix later      26   Usage of deprecated trait                                   
                    Drupal\Tests\field\Traits\EntityReferenceTestTrait in class 
                    Drupal\Tests\default_content\Kernel\ExporterIntegrationTest.
                    Deprecated in drupal:10.2.0 and is removed from             
                    drupal:11.0.0. Use                                          
                    Drupal\Tests\field\Traits\EntityReferenceFieldCreationTrait 
                    instead.                                                    
--------------------------------------------------------------------------------

FILE:
modules/contrib/default_content/tests/src/Kernel/MenuLinkContentNormalizerTest.p
hp

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Fix later      19   Usage of deprecated trait                                   
                    Drupal\Tests\field\Traits\EntityReferenceTestTrait in class 
                    Drupal\Tests\default_content\Kernel\MenuLinkContentNormalize
                    rTest. Deprecated in drupal:10.2.0 and is removed from      
                    drupal:11.0.0. Use                                          
                    Drupal\Tests\field\Traits\EntityReferenceFieldCreationTrait 
                    instead.                                                    
--------------------------------------------------------------------------------

FILE:
modules/contrib/default_content/tests/src/Kernel/ParagraphNormalizerTest.php

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Fix later      24   Usage of deprecated trait                                   
                    Drupal\Tests\field\Traits\EntityReferenceTestTrait in class 
                    Drupal\Tests\default_content\Kernel\ParagraphNormalizerTest.
                    Deprecated in drupal:10.2.0 and is removed from             
                    drupal:11.0.0. Use                                          
                    Drupal\Tests\field\Traits\EntityReferenceFieldCreationTrait 
                    instead.                                                    
--------------------------------------------------------------------------------

FILE:
modules/contrib/default_content/tests/src/Kernel/TranslationNormalizerTest.php

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Fix later      19   Usage of deprecated trait                                   
                    Drupal\Tests\field\Traits\EntityReferenceTestTrait in class 
                    Drupal\Tests\default_content\Kernel\TranslationormalizerTest
                    . Deprecated in drupal:10.2.0 and is removed from           
                    drupal:11.0.0. Use                                          
                    Drupal\Tests\field\Traits\EntityReferenceFieldCreationTrait 
                    instead.                                                    
--------------------------------------------------------------------------------

@chandu7929 - There is a separate issue to fix those deprecations hence i reverted those commit and added it here - https://www.drupal.org/project/default_content/issues/3415901 📌 EntityReferenceTestTrait deprecated Needs review

Verified MR 46 change and its look good to me, hence RTBC.

D11 is not going to work with a phpstan deprecation like this:

Line tests/src/Kernel/TranslationNormalizerTest.php
------ -----------------------------------------------------------------
19 Usage of deprecated trait
Drupal\Tests\field\Traits\EntityReferenceTestTrait in class
Drupal\Tests\default_content\Kernel\TranslationormalizerTest:
in drupal:10.2.0 and is removed from drupal:11.0.0. Use
\Drupal\Tests\field\Traits\EntityReferenceFieldCreationTrait
instead.

Unfortunately, fixing this means we can no longer test on 10.1 and lower.

One way to verify D11 test are actually working is to use a lenient configuration. like this: https://git.drupalcode.org/project/paragraphs/-/merge_requests/115/diffs..., then it should be able to install and only the tests that actually require those additional modules should fail.

@berdir - There is a separate issue created for fixing these deprecations, kindly have a look at this - https://www.drupal.org/project/default_content/issues/3415901 📌 EntityReferenceTestTrait deprecated Needs review

ankitv18 → changed the visibility of the branch project-update-bot-only to hidden.

MR!46 is ready for review ~~ I've made a fix of deprecation trait in this and its related issue i.e https://www.drupal.org/project/default_content/issues/3415901 📌 EntityReferenceTestTrait deprecated Needs review (If you merge this one first then I'll revert the changes in MR!46)

I was a bit concerned about the hal related test fails I saw locally, but it's caused by hal, not default_content and it's fixed by ✨ compatible with Drupal 11 Needs review