Contrib.social

ExistsConstraintValidator should ignore NULL values and treat `core` as a valid module

Open on Drupal.org →
Created on 7 March 2024, 8 months ago
Updated 22 March 2024, 8 months ago

Problem/Motivation

  1. Any value where the ExistsConstraint is used may be marked optional. So NULL should be allowed. (Similar issue for another constraint: 🐛 ConfigExistsConstraintValidator should ignore NULL values Active )
  2. Drupal core has a special "module" called core. This "module" is always installed. It is used for all plugins in the core/lib directory: no concrete module is then the provider of such a plugin, but core is. Hence it should be treated as a valid value.

Both of these problems were surfaced in 📌 Make Block config entities fully validatable Fixed .

Steps to reproduce

N/A

Proposed resolution

  1. Allow NULL always, allow core if the type option is set to module.
  2. Test coverage.

Remaining tasks

None.

User interface changes

None.

API changes

None.

Data model changes

None.

Release notes snippet

N/A

🐛 Bug report
Status

Fixed

Version

10.2 ✨

Component
Configuration  →

Last updated 1 day ago

Created by

🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @wim leers
  • Merge request !6956Resolve #3426324 "Existsconstraintvalidator fixes" → (Open) created by wim leers
  • Pipeline finished with Canceled
    8 months ago
    Total: 46s
    #113722
  • Issue was unassigned.
  • Status changed to Needs review 8 months ago
  • Comment 8 months ago →
    🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺

    Test-only CI job should fail.

  • Pipeline finished with Success
    8 months ago
    Total: 483s
    #113723
  • Status changed to RTBC 8 months ago
  • Comment 8 months ago →
    🇺🇸United States smustgrave

    Test-only has already been ran

    There was 1 failure:
1) Drupal\KernelTests\Core\Extension\ExtensionExistsConstraintValidatorTest::testValidation
Failed asserting that actual size 1 matches expected size 0.
/builds/issue/drupal-3426324/vendor/phpunit/phpunit/src/Framework/Constraint/Constraint.php:121
/builds/issue/drupal-3426324/vendor/phpunit/phpunit/src/Framework/Constraint/Constraint.php:55
/builds/issue/drupal-3426324/core/tests/Drupal/KernelTests/Core/Extension/ExtensionExistsConstraintValidatorTest.php:38
/builds/issue/drupal-3426324/vendor/phpunit/phpunit/src/Framework/TestResult.php:728
FAILURES!
Tests: 1, Assertions: 1, Failures: 1.

    This one had to read a few times but haven't used ExistsConstraint much yet. But idea of if module type and core is used makes sense.

    Since this appears to be a blocker going to mark it.

  • Comment 8 months ago →
    🇬🇧United Kingdom alexpott 🇪🇺🌍

    Committed and pushed ab695b5cc6 to 11.x and d4c468d72b to 10.3.x and 5f758d452e to 10.2.x. Thanks!

  • Comment 8 months ago →
    System Message
    • alexpott → committed 5f758d45 on 10.2.x 
      Issue #3426324 by Wim Leers: ExistsConstraintValidator should ignore...
  • Comment 8 months ago →
    System Message
    • alexpott → committed d4c468d7 on 10.3.x 
      Issue #3426324 by Wim Leers: ExistsConstraintValidator should ignore...
  • Status changed to Fixed 8 months ago
  • Comment 8 months ago →
    System Message
    • alexpott → committed ab695b5c on 11.x 
      Issue #3426324 by Wim Leers: ExistsConstraintValidator should ignore...
  • Comment 8 months ago →
    System Message

    Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024