Return early in \Drupal\layout_builder\InlineBlockEntityOperations::handlePreSave if the entity is syncing

Created on 5 March 2024, 10 months ago
Updated 21 March 2024, 9 months ago

Problem/Motivation

block_content_post_update_set_owner will take a lot longer for folks using layout builder on block_content entities as \Drupal\layout_builder\InlineBlockEntityOperations::handlePreSave will run

Steps to reproduce

Proposed resolution

Have \Drupal\layout_builder\InlineBlockEntityOperations::handlePreSave return early if the entity is syncing.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

πŸ› Bug report
Status

Fixed

Version

10.3 ✨

Component
Layout builderΒ  β†’

Last updated about 2 hours ago

Created by

πŸ‡¦πŸ‡ΊAustralia larowlan πŸ‡¦πŸ‡ΊπŸ.au GMT+10

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @larowlan
  • First commit to issue fork.
  • Status changed to Needs review 10 months ago
  • πŸ‡·πŸ‡΄Romania amateescu

    I bumped into the same problem earlier this week, but from a different angle: publishing a workspace with nodes that contain inline blocks would duplicate those blocks.

  • Pipeline finished with Success
    10 months ago
    Total: 489s
    #113639
  • First commit to issue fork.
  • Status changed to RTBC 10 months ago
  • πŸ‡ΊπŸ‡ΈUnited States smustgrave

    Applied a nitpicky suggestion

    Ran the test-only feature here https://git.drupalcode.org/issue/drupal-3425890/-/jobs/1014885

    Change makes sense.

    LGTM

  • πŸ‡ΊπŸ‡ΈUnited States smustgrave

    Rerunning that failure

    Can't imagine adding a :void caused

        Testing Drupal\Tests\help\Functional\Update\HelpTopicsMerge
        F                                                                   1 / 1
        (100%)
        
        Time: 00:00.653, Memory: 4.00 MB
        
        There was 1 failure:
        
        1) Drupal\Tests\help\Functional\Update\HelpTopicsMerge::testHelpTopicsMerge
        Failed to run installer database tasks: Failed to connect to your database
        server. The server reports the following message: SQLSTATE[HY000] [2002]
        Connection refused [Tip: This message normally means that there is no MySQL
        server running on the system or that you are using an incorrect host name
        or port number when trying to connect to the server. You should also check
        that the TCP/IP port you are using has not been blocked by a firewall or
        port blocking service.] .Is the database server running?Does the database
        exist or does the database user have sufficient privileges to create the
        database?Have you entered the correct database name?Have you entered the
        correct username and password?Have you entered the correct database
        hostname and port number?
    
  • Pipeline finished with Success
    10 months ago
    Total: 1025s
    #113838
    • catch β†’ committed 10d91491 on 10.3.x
      Issue #3425890 by amateescu, smustgrave, larowlan: Return early in \...
    • catch β†’ committed 44999a9a on 11.x
      Issue #3425890 by amateescu, smustgrave, larowlan: Return early in \...
  • Status changed to Fixed 10 months ago
  • πŸ‡¬πŸ‡§United Kingdom catch

    Committed/pushed to 11.x and cherry-picked to 10.3.x, thanks!

  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024