development.services.yml should document that parameters are only shallow-merged

We are going to work on this issue as part of the Novice contribution workshop of Symetris → .

We added documentation in development.services.yml about the Shallow Merge of the files that provide container definitions.

Wow, that's a lot of docs! It's great work, but I think it's rather too much for here.

I think we need to say that parameters here are shallow merged (no need to capitalise), and say that if overriding any values, the whole of the array needs to be copied from sites/default/default.services.yml.

I don't think we need code examples, though what you've written for the MR could be moved to https://www.drupal.org/docs/develop/development-tools → as a new page about setting up the development.services.yml file.

No worries. We've learned a lot about container definitions and shallow merge ;)

Here is a shorter version of the documentation.

The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

KarimB → changed the visibility of the branch 11.x to hidden.

Believe it needs to be rebased.

It seems to me we need to change the scaffold file as well (see the pipeline failure).

I performed Novice Triage on this issue. I am leaving the Novice tag on this issue because we should be able to update the issue summary with the work done so far and what is remaining to be done and complete any additional work and provide a review of the merge request.

We are working on this issue on Drupalcon Portland 2024 contribution day!
@arparker @msandoval @anand48 @farnoosh @amriez @bember

First step is to rebase the patch against Drupal 11

Here's a draft for the helper text:

Please note that overriding a setting requires defining default values for all its sub-settings (not only the things you want to override). For example, if you want to enable render cache debug output, the following code will crash the site:

-> Bad example from ticket description

The correct procedure would be:

-> Correct example from ticket description

Could someone please weigh in? Thanks!

Working on this during DrupalCon 2024.

The pipeline is failing during the Test: "PHPUnit Unit".

rebased 3425692--development-services-docs against 11.x

We are making progress at Drupalcon Portland 2024 contribution day on this issue with DrupalPod! The team has identified the two files development.services.yml that exist and updated them to match. We are working on testing the build and are investigating a new set of failures in the build with nightwatch and javascript test failures. @howard.lewitt is helping, too!

I retroactively added the Portland2024 tag to the issue because contributors were working on this issue on 2024.05.08.

Rebased again and all tests pass.

I have reviewed the merge request. The code changes look good. All of the tests are passing.

Thanks for working on this! There are two branches but no open merge requests; please open a merge request on the branch that has the correct changes, and hide the other branch so as not to confuse reviewers.

bember → changed the visibility of the branch drupal-3425692--msandoval to hidden.

bember → changed the visibility of the branch 3425692--development-services-docs to hidden.

bember → changed the visibility of the branch 11.x to active.

@longwave thanks for catching this. It's now fixed and since @julieelman already reviewed 6979, I'm moving this back to RTBC.

One small typo. Other than that looks good.

I think I can handle this.

CI pipeline still passes. Moving back to RBTC.

Committed and pushed fe3721e8a2 to 11.x and 00317c88e0 to 11.0.x and b7542fbcf4 to 10.4.x and 2bbb3d82f3 to 10.3.x. Thanks!

xjm → credited anand48 → .

xjm → credited arparker → .

xjm → credited chloewebcraft → .

Adding credit for contribution day contributors per #14. Thanks everyone!

Also properly crediting @longwave for the commit, since d.o ate his credit.

Automatically closed - issue fixed for 2 weeks with no activity.