- Issue created by @camilledavis
- Status changed to Needs review
10 months ago 8:43pm 5 March 2024 - π¨π¦Canada mgifford Ottawa, Ontario
I like this idea, but I'm missing something.
https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Attribut...
I couldn't find
aria-current="page"
in the page.
https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Attribut...Here's a snapshot of what I see with SimplyTest.me & D10:
<li class="tabs__tab js-tab is-active js-active-tab" data-original-order="1"> <a href="/user/1/shortcuts" class="tabs__link js-tabs-link is-active" data-drupal-link-system-path="user/1/shortcuts">Shortcuts</a> <button class="reset-appearance tabs__trigger" aria-label="Tabs display toggle" data-drupal-nav-tabs-trigger=""> <svg fill="none" height="16" viewBox="0 0 16 16" width="16" xmlns="http://www.w3.org/2000/svg"><path clip-rule="evenodd" d="m15 9h-14c-.56016 0-1-.43984-1-1s.43984-1 1-1h14c.5602 0 1 .43984 1 1s-.4398 1-1 1zm0-5h-14c-.56016 0-1-.43984-1-1s.43984-1 1-1h14c.5602 0 1 .43984 1 1s-.4398 1-1 1zm-14 8h14c.5602 0 1 .4398 1 1s-.4398 1-1 1h-14c-.56016 0-1-.4398-1-1s.43984-1 1-1z" fill="#003ECC" fill-rule="evenodd"></path></svg> </button> </li>
I've uploaded some screenshots with/without the patch.
I'd love to know what I am missing.
- πΊπΈUnited States smustgrave
Maybe it's just claro
I'm on 11.x the content view and see aria-current and the visually-hidden
I believe aria-current it was added in this issue: https://www.drupal.org/project/drupal/issues/3038523 π Add aria-current attribute to navigation items RTBC
- π¨π¦Canada mgifford Ottawa, Ontario
Thanks smustgrave - I appreciate you verifying that. I wasn't starting with D11 but obviously should have been here.
That makes sense @camille.davis@civicactions.com
I tested with code without that.
In which case I don't have a problem removing the redundant text.. Who wants redundant text!
- π©πͺGermany rkoller NΓΌrnberg, Germany
but talking of the link provided in #7 π "Local Tasks" behaves as navigation bar but uses "tab" language Needs review . @larowlan provided a few examples in [3038523-38] where the aria-current is used. so it isn't only about local tasks but also for menu linkes, breadcrumbs and pagers? would it make sense to extend the scope of this issue or open up a follow up issue to make things consistent across the board?
but overall definitely a good and reasonable change
- Status changed to RTBC
10 months ago 3:18pm 7 March 2024 - πΊπΈUnited States smustgrave
Per #9 I checked pagination and am seeing the same thing. Opened π Check breadcrumbs, pagination, and menu links for redundant visually hidden Active to research those other components.
- π¬π§United Kingdom alexpott πͺπΊπ
Committed and pushed 205d4bfbda to 11.x and dde87be077 to 10.3.x. Thanks!
Backported to 10.3.x so this will be in the next minor release (same as π Add aria-current attribute to navigation items RTBC ) since it is a markup change.
- Status changed to Fixed
10 months ago 1:19pm 8 March 2024 -
alexpott β
committed dde87be0 on 10.3.x
Issue #3424746 by camille.davis@civicactions.com, mgifford, smustgrave,...
-
alexpott β
committed dde87be0 on 10.3.x
-
alexpott β
committed 79d8c3c6 on 11.x
Issue #3424746 by camille.davis@civicactions.com, mgifford, smustgrave,...
-
alexpott β
committed 79d8c3c6 on 11.x
Automatically closed - issue fixed for 2 weeks with no activity.