Let's use subforms for inline blocks

Created on 29 February 2024, 4 months ago
Updated 1 March 2024, 4 months ago

Problem/Motivation

I think a subform is going to be more flexible and robust. Specifically for nested AJAX calls.

✨ Feature request
Status

Closed: duplicate

Version

11.0 πŸ”₯

Component
Layout builderΒ  β†’

Last updated about 17 hours ago

Created by

πŸ‡ΊπŸ‡ΈUnited States Tim Bozeman

Live updates comments and jobs are added and updated live.
  • Needs issue summary update

    Issue summaries save everyone time if they are kept up-to-date. See Update issue summary task instructions.

Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @Tim Bozeman
  • Merge request !6834Use a subform for inline blocks. β†’ (Open) created by Tim Bozeman
  • πŸ‡ΊπŸ‡ΈUnited States Tim Bozeman
  • Pipeline finished with Failed
    4 months ago
    Total: 487s
    #107308
  • Status changed to Needs work 4 months ago
  • πŸ‡ΊπŸ‡ΈUnited States smustgrave
        Testing
        Drupal\Tests\content_moderation\Functional\LayoutBuilderContentModerationIntegrationTest
        .E                                                                  2 / 2
        (100%)
        
        Time: 00:23.482, Memory: 4.00 MB
        
        There was 1 error:
        
        1)
        Drupal\Tests\content_moderation\Functional\LayoutBuilderContentModerationIntegrationTest::testModeratedInlineBlockBundles
        Behat\Mink\Exception\ElementNotFoundException: Form field with
        id|name|label|value "settings[block_form][body][0][value]" not found.
        
        /builds/issue/drupal-3424738/vendor/behat/mink/src/WebAssert.php:731
        /builds/issue/drupal-3424738/core/tests/Drupal/Tests/UiHelperTrait.php:85
        /builds/issue/drupal-3424738/core/modules/content_moderation/tests/src/Functional/LayoutBuilderContentModerationIntegrationTest.php:186
        /builds/issue/drupal-3424738/vendor/phpunit/phpunit/src/Framework/TestResult.php:728

    Wonder if test coverage should be added to show how this is better too? Thoughts.

  • πŸ‡³πŸ‡ΏNew Zealand DanielVeza Brisbane, AU

    I haven't gone through the code yet, but IMO the issue summary needs to be more fleshed out. What is the current issue, how does this make it better etc.

  • Status changed to Closed: duplicate 4 months ago
  • πŸ‡ΊπŸ‡ΈUnited States Tim Bozeman

    Oh whoops. πŸ˜…

    As timplunkett pointed out in slack, this is a duplicate of πŸ› Sub form not passed to BlockPlugin's submit callback Needs work

Production build 0.69.0 2024