Fix the issues reported by phpcs

Fix The All phpcs issues please review it.

Hi

I applied your patch #2 and it didn't apply properly and there are still PHPCS issues being flagged.

➜  database_dashboard git:(master) ✗ curl https://www.drupal.org/files/issues/2024-02-21/3422911-2.patch | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  2297  100  2297    0     0   3570      0 --:--:-- --:--:-- --:--:--  3605
patching file database_dashboard.info.yml
1 out of 1 hunks failed--saving rejects to database_dashboard.info.yml.rej
patching file database_dashboard.module
patching file 'src/Controller/DatabaseDashboardController.php'
➜  database_dashboard git:(master) ✗ ..
➜  contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml database_dashboard 

FILE: /Users/clarksubing-subing/Projects/d9/d9-local/web/modules/contrib/database_dashboard/css/dashboard.css
-------------------------------------------------------------------------------------------------------------
FOUND 9 ERRORS AFFECTING 6 LINES
-------------------------------------------------------------------------------------------------------------
  2 | ERROR | [x] Selectors must be on a single line
  3 | ERROR | [x] Multiple selectors should each be on a single line
  3 | ERROR | [x] Selectors must be on a single line
  4 | ERROR | [x] Selectors must be on a single line
  5 | ERROR | [x] Multiple selectors should each be on a single line
  5 | ERROR | [x] Selectors must be on a single line
  6 | ERROR | [ ] Style definitions must end with a semicolon
 18 | ERROR | [x] There must be no space before a colon in a style definition
 18 | ERROR | [x] Expected 1 space after colon in style definition; 0 found
-------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 8 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------


FILE: ...rs/clarksubing-subing/Projects/d9/d9-local/web/modules/contrib/database_dashboard/database_dashboard.info.yml
-------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 2 LINES
-------------------------------------------------------------------------------------------------------------------
 1 | WARNING | Remove "project" from the info file, it will be added by drupal.org packaging automatically
 1 | WARNING | Remove "datestamp" from the info file, it will be added by drupal.org packaging automatically
 1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging automatically
 7 | WARNING | All dependencies must be prefixed with the project name, for example "drupal:"
-------------------------------------------------------------------------------------------------------------------

Time: 284ms; Memory: 10MB

➜  contrib git:(master) ✗ 

No issues in the MR. Please review the MR1.

Hi,
Applied the MR!1,found no phpcs errors and warnings.

Hi

I applied MR !1 again and I can still see some PHPCS errors

➜  database_dashboard git:(master) ✗ curl https://git.drupalcode.org/project/database_dashboard/-/merge_requests/1.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  2495    0  2495    0     0   5172      0 --:--:-- --:--:-- --:--:--  5286
patching file database_dashboard.info.yml
1 out of 1 hunks failed--saving rejects to database_dashboard.info.yml.rej
patching file database_dashboard.module
patching file 'src/Controller/DatabaseDashboardController.php'
➜  database_dashboard git:(master) ✗ ..
➜  contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml database_dashboard 

FILE: ...jects/d9/d9-local/web/modules/contrib/database_dashboard/css/dashboard.css
--------------------------------------------------------------------------------
FOUND 9 ERRORS AFFECTING 6 LINES
--------------------------------------------------------------------------------
  2 | ERROR | [x] Selectors must be on a single line
  3 | ERROR | [x] Multiple selectors should each be on a single line
  3 | ERROR | [x] Selectors must be on a single line
  4 | ERROR | [x] Selectors must be on a single line
  5 | ERROR | [x] Multiple selectors should each be on a single line
  5 | ERROR | [x] Selectors must be on a single line
  6 | ERROR | [ ] Style definitions must end with a semicolon
 18 | ERROR | [x] There must be no space before a colon in a style definition
 18 | ERROR | [x] Expected 1 space after colon in style definition; 0 found
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 8 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------


FILE: ...9-local/web/modules/contrib/database_dashboard/database_dashboard.info.yml
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 2 LINES
--------------------------------------------------------------------------------
 1 | WARNING | Remove "project" from the info file, it will be added by
   |         | drupal.org packaging automatically
 1 | WARNING | Remove "datestamp" from the info file, it will be added by
   |         | drupal.org packaging automatically
 1 | WARNING | Remove "version" from the info file, it will be added by
   |         | drupal.org packaging automatically
 7 | WARNING | All dependencies must be prefixed with the project name, for
   |         | example "drupal:"
--------------------------------------------------------------------------------

Time: 200ms; Memory: 10MB

➜  contrib git:(master) ✗ 

hi ,
@clarkssquared Please use this command
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,yml,twig modules/contrib/database_dashboard/

GitLAb CI does not report further PHP_CodeSniffer warnings/errors. The MR !1 is ready to go.

Cheers, merged, creating a release soon.

Automatically closed - issue fixed for 2 weeks with no activity.