"More" link not taking default arguments into account

The fix might be easy. Before #981870 → , the code part mentioned above did only run if default_argument_skip_url was set to TRUE. Since that setting has been entirely removed, I believe that we can completely delete that code section (instead of always running it, as it is now).

Created an MR.

Thanks for reporting,

Will need a failing test to show the issue.

MR target should be 11.x as the current development branch.

FYI no need to upload test-only patches. That feature is in gitlab now.

Thanks for the info, @smustgrave. Then the test documentation → is probably not up-to-date yet ;)

I've added a test case in the MR and changed the target to 11.x.

Ok, seems like there was indeed an issue in 11.x making the test fail. I've merged a fix from 11.x and now all tests are passing again :)

Also the test-only changes show the failing test case, so this issue should now be ready for review.

MR at #09 seems good to me, it also passes test cases over the pipeline.
Moving the issue to RTBC.

@smustgrave Please review and share if any other change is required.

I'm pretty sure this issue is correct and the way 📌 Skip default argument for view URL does not work and never has so it can be removed Fixed was implemented was incorrect. But before we merge this it'd be great if the people who work on that issue add a +1.

I think the fact that no test coverage is changed here proves that core actually had no test coverage of what they were changing in that issue.

Whoops, in the original issue we got the condition the wrong way round.

Committed and pushed to 11.x and 10.3.x, backported to 10.2.x as an eligible bug fix. Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.