Fixing source IDs with spaces in Sql.php

Diff committed on branch 3422603-fixing-source-ids

Also should fix not only spaces but also special characters in migrate source CSV.

@b2f Changes to core are applied to 11.x first, and then possibly cherry-picked down to 10.2.x-dev. Can you rebase your branch (or create a new branch) against 11.x and open an MR?

@godotislate, 11.x done in 3422603- and 3422603-fixing-source-id-for-csv 10.2.x (sorry about branch names)

Thanks, @bdf. I ran into the issue with having spaces in column names in my CSV a few months ago, so being able to migrate those without editing the source CSV or other handling would be ideal.

That being said, looks like there are quite a few automated test failures to address, and there probably needs to be test to cover that source ID keys with spaces or special characters works correctly.

Made some tweaks to address failing tests.

Add test coverage for source field names with spaces and special characters.

godotislate → changed the visibility of the branch 3422603-fixing-source-ids to hidden.

godotislate → changed the visibility of the branch 3422603-fixing-source-id-for-csv to hidden.

Apologize had this one open the other and didn't finish

Removing the tests tag as that was added here https://git.drupalcode.org/issue/drupal-3422603/-/jobs/909281

Summary appears to match the solution and didn't cause any failures so believe no functionality has been lost.

Believe this is good to go.

This is a bug fix and and nice one at that. Backporting to 10.2.x as this is a non-disruptive bug fix.

Committed and pushed 56f8d7594c to 11.x and d67efa58fc to 10.3.x and a30616fb87 to 10.2.x. Thanks!

Can someone with access please close the MR? Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.