Convert Tip plugin discovery to attributes

Know tour is being deprecated but as the maintainer for when it moves to core 100% want this included :)

Fixed one minor thing in above commit. No impact on functionality as such.
Keeping in RTBC only.

Know tour is being deprecated but as the maintainer for when it moves to core 100% want this included :)

FWIW you'll need a branch that is Drupal 10.2+ and drop support for 10.1

Since a tour contrib split has already happened maybe this should just be postponed and moved to contrib.

I'm keeping 1.0.x branch as a pure copy.

Will start a 2.0.x branch with fixes

I think we can move this to `tour` module's issue queue by changing the project.
I'm not quite sure if this is the right approach?

Yea just going to do that.

created new MR https://git.drupalcode.org/project/tour/-/merge_requests/4 for review

feel free to update target branch to 2.0.x when it will be created

@smustgrave, I think we need to spin up a new branch since you've mentioned that new changes should go into. 2.0.x
We can update the destination for the PR once it is done.

Holding on the 2.0.x branch till tour is officially removed and I know I won’t be doing another sub tree split.

Changing this from a child of the core meta issue to a related issue. That's just to make it obvious that completing the core issue is not dependent on an issue in contrib.

This is good to go for 2.0.x branch but appears to have failures.

smustgrave → changed the visibility of the branch 3420995-convert-tip-plugin to hidden.

FYI this can be merged into 2.0.x unfortunately I've hit a bug where my access is in limpo because of the project move. The MR for tour though appears to have the attribute still in core.

smustgrave → closed merge request !4

Will be included in 2.x alpha1 release.

Automatically closed - issue fixed for 2 weeks with no activity.