- Issue created by @quietone
- Status changed to Needs review
10 months ago 6:46am 12 February 2024 - ๐ฎ๐ณIndia djsagar
@quietone pipelines passed the cspell error, you can close this.
Thanks!
- Status changed to RTBC
10 months ago 3:20pm 12 February 2024 - ๐บ๐ธUnited States smustgrave
Left a comment about one of the lines for further discussion. But items removed from the dictionary matches up with proposal. Moving to ignore lines seems fine.
- ๐ง๐ชBelgium BramDriesen Belgium ๐ง๐ช
Added 2 comments. But should not block this I think.
- Status changed to Needs work
10 months ago 11:40am 18 February 2024 - ๐ฌ๐งUnited Kingdom longwave UK
Dictionary needs rerolling after another cspell issue was committed.
"alternatif" is French.
"ragdoll" could be hyphenated or replaced with another word that is in the dictionary. Same for a number of the other cases.
But equally I don't think it's worth going through and sanitising all of these, easier just to ignore them in the one or two places they are used.
- Status changed to Needs review
10 months ago 9:04am 5 March 2024 - ๐ณ๐ฟNew Zealand quietone
I agree that some could be sanitized but we risk being less inclusive and remove some of the fun too.
- Status changed to RTBC
10 months ago 1:10pm 5 March 2024 - ๐ง๐ชBelgium BramDriesen Belgium ๐ง๐ช
To me this looks okay. Also no failing tests so I think we can RTBC this.
- ๐ฌ๐งUnited Kingdom longwave UK
Committed and pushed 991ec83120 to 11.x and 361a968658 to 10.3.x. Thanks!
-
longwave โ
committed 361a9686 on 10.3.x
Issue #3420740 by quietone, BramDriesen, smustgrave: Fix words in tests...
-
longwave โ
committed 361a9686 on 10.3.x
-
longwave โ
committed 991ec831 on 11.x
Issue #3420740 by quietone, BramDriesen, smustgrave: Fix words in tests...
-
longwave โ
committed 991ec831 on 11.x
- Status changed to Fixed
10 months ago 11:13pm 6 March 2024 Automatically closed - issue fixed for 2 weeks with no activity.