Remove ContainerAwareTrait from session middleware

We can't use !service_closure syntax in services.yml because the YAML parser does not support it: 📌 Support Yaml::PARSE_CUSTOM_TAGS in \Drupal\Component\Serial::decodeization\YamlSymfony:: Needs work

However we can enable autowiring instead and use the #[AutowireServiceClosure] attribute.

Functional tests are not very happy.

session_handler needs to be explicitly autowired.

Not sure I'm taking the right approach here. Maybe we just inject a session closure directly into the session middleware?

longwave → changed the visibility of the branch 3420215-remove-containerawaretrait-from to hidden.

longwave → closed merge request !6516

This simpler approach seems to work. Unsure if this needs BC - are middleware services part of the API?

are middleware services part of the API?

I'd put them in the same bracket as event subscribers and tagged services (and hook implementations) - so @internal.

I'd put them in the same bracket as event subscribers and tagged services (and hook implementations) - so @internal.

We might want to documen that here: https://www.drupal.org/about/core/policies/core-change-policies/bc-policy →

If we do treat it like @internal, I would say this is RTBC.

Since it's just adding another concrete example to an e.g., made the edit: https://www.drupal.org/about/core/policies/core-change-policies/bc-polic... →

Thanks @catch
_hats were tipped_

The service closure usage is nice and will help with issues like 📌 Find an alternative to trigger_error in Drupal\Core\EventSubscriber\RedirectResponseSubscriber::checkRedirectUrl Active , and maybe removing our own lazy/proxy services stuff too.

Committed/pushed to 11.x and cherry-picked to 10.3.x, thanks!

Automatically closed - issue fixed for 2 weeks with no activity.