- Issue created by @eelkeblok
- Merge request !379Add gin/breadcrumb as dependency to gin_horizontal_toolbar → (Open) created by eelkeblok
- Status changed to Needs review
over 1 year ago 10:41am 4 February 2024 - 🇮🇳India Kanchan Bhogade
Hi @eelkeblok
Unable to reproduce the issue, followed the given steps.
Please share more details like the Drupal version and screenshots. - 🇧🇪Belgium johanvdr
Confirming the issue at hand with updating to the current version of gin theme: 3.0.0-rc9.
The ordered list is showing the numbering in the breadcrumb. - 🇨🇭Switzerland saschaeggi Zurich
We moved the dependency to be included automatically which seems it doesn't get exposed to the frontend.
We might want to re-add the dependency on all navigation variants.
- 🇳🇱Netherlands eelkeblok Netherlands 🇳🇱
@saschaeggi: Do you know in which issue that was changed? Maybe it is something that doesn't work when adding the styling in gin toolbar.
- 🇳🇱Netherlands eelkeblok Netherlands 🇳🇱
TY @jrockowitz. That makes it much clearer. The dependency is now added in Gin's .theme file, which doesn't get any say in the matter within the frontend theme where Gin Toolbar needs it.
- 🇮🇳India Kanchan Bhogade
Hi
Verified the issue on Drupal version 10.2.2
for the Gin theme (8.x-3.0-rc9) with Gintoolbar (1.0-rc5)
Successfully able to reproduce the issue (before screenshot)Testing Steps
- Install drupal version10.2.2
- Install the Gin theme(8.x-3.0-rc9) with module Gin toolbar (1.0-rc5)
- Configure Gin to use the horizontal toolbar
- Navigate to the frontend (i.e. not Gin itself, but a different theme), notice the 1. prepended to the "Back to administration" link
Tested and verified for MR !379 on Drupal 10.2 for the gin theme
MR Applied Successfully...Test Result:
The 1. prepended to the "Back to administration" link is removed after applying MRAttaching screenshot for reference
RTBC+1
keeping in to "Needs review" for code review - Status changed to Needs work
about 1 year ago 1:30pm 21 February 2024 - 🇳🇱Netherlands eelkeblok Netherlands 🇳🇱
I think neither my own nor @johanvdr's solutions will cut the mustard, given the changes in 🐛 Sticky shadow position without toolbar Fixed ; there, the dependency is removed from several libraries. I'll create an MR to restore them, but I am not convinced that will not reintroduce the problem of the issue where they were removed. Or maybe adding them back is redundant for Gin itself, but needed for Gin Toolbar (in that case, we could also consider adding them in a library_info_alter in Gin Toolbar).
- 🇳🇱Netherlands eelkeblok Netherlands 🇳🇱
eelkeblok → changed the visibility of the branch 8.x-3.x to hidden.
- Status changed to Needs review
about 1 year ago 1:36pm 21 February 2024 - Status changed to RTBC
about 1 year ago 3:55pm 21 February 2024 - Status changed to Fixed
about 1 year ago 4:02pm 21 February 2024 Automatically closed - issue fixed for 2 weeks with no activity.