- Issue created by @kksandr
- Merge request !6431Issue #3418863 by kksandr: fix sticky table header β (Closed) created by Unnamed author
- Status changed to Needs review
12 months ago 11:18am 2 February 2024 - Status changed to Needs work
12 months ago 3:54pm 2 February 2024 - πΊπΈUnited States smustgrave
If this is only reproducible with Gin and can't be replicated in core should the fix go over there?
Will need a test case showing the issue.
- π¨πSwitzerland saschaeggi Zurich
@smustgrave the culprint of the issue seems to be
his.$stickyTable[0].style.width = this.$originalTable.outerWidth();
as
outerWidth()
will provide a number without a unit and therefore can cause issues in (some) browsers (like Firefox).The MR adds `px` as a unit to being more specific which fixes the issue.
- πΊπΈUnited States smustgrave
Thanks for digging into it. Maybe this doesn't require tests after all? But would be nice to be able to check claro for the bug
- Status changed to Needs review
10 months ago 4:11pm 21 March 2024 - πΊπΈUnited States smustgrave
Just curious, does π Sticky table header is not sticky if --drupal-displace-offset-top is not defined Fixed have any impact here?
- Status changed to RTBC
10 months ago 2:18pm 25 March 2024 - πΊπΈUnited States smustgrave
This change seems so small I take back my previous comment for tests. Lets see what the committers say.
- Status changed to Fixed
10 months ago 3:53pm 25 March 2024 Automatically closed - issue fixed for 2 weeks with no activity.