Fix strict type errors: Convert remaining usages of FormattableMarkup to strings in core Functional tests

Additional changes look fine to me. Just did the eye test

To prove that this is the last of the strict type issues and we haven't missed any, see results from the latest rebase at https://git.drupalcode.org/issue/drupal-3399746/-/pipelines/86427/test_r...

I read the MR and the changes look fine to me. I then applied the diff and ran this yucky grep.

$ grep --exclude-dir={node_modules,vendor} -r "assert" core | grep -vi assertsession | grep Functional | grep  Formattable | awk -F: '{print $1}' | sort -u 
core/lib/Drupal/Core/Test/FunctionalTestSetupTrait.php
core/modules/views/tests/src/Functional/Plugin/DisplayTest.php

DisplayTest does not need to be changed. But doesn't this need to be changed, https://git.drupalcode.org/project/drupal/-/blob/11.x/core/lib/Drupal/Co... ? Or is that in another issue. I did read the similar issues but I didn't see it.

Interesting. The tests don't fail when adding strict types. Is this dead code? Will investigate tomorrow.

Oh, this directory is not in any of the patterns we're matching. I dare say there are more issues to solve in the directory. Maybe we can leave that for another issue?

I updated FunctionalTestSetupTrait because it's easier to do than debating whether to do it or not. That said, it won't get the strict_types treatment because the Drupal\Core\Test namespace is kind of special. I don't know much about it, but it includes code that is reference by non-test code, so we need to be careful not to break anything. For example, \Drupal\Core\Test\HttpClientMiddleware\TestHttpClientMiddleware is referenced by \Drupal\Core\CoreServiceProvider, albeit in a function named registerTest. I also don't understand why AssertMailTrait and other traits are in here and not in Drupal\Tests\Traits.

Also found these:

📌 Document the purpose of code in Drupal\Core\Test Postponed
📌 move things from lib/Drupal/Core/Test to core/tests Active
📌 Create a new component for the test runner Active

Changes in MR still appear fine.

Should a follow up be made to revisit Drupal\Core\Test

> Should a follow up be made to revisit Drupal\Core\Test

I think 📌 move things from lib/Drupal/Core/Test to core/tests Active covers anything that will be moved to core/tests, and the remaining files in Drupal\Core\Test can be handled when/if strict types is added to the rest of the runtime code.

Committed to 11.x and cherry-picked to 10.2.x

Thanks!

Forgot to comment that I agree that a follow up is not needed.

Automatically closed - issue fixed for 2 weeks with no activity.

mstrelan → closed merge request !6400