Fix strict type errors: Convert FormattableMarkup to strings (simple replacement) in core Functional tests

Alternative is to cast FormattableMarkup to string before passing to assert* methods, but then using FM in the first place is a little silly. Or there is sprintf but that didn't go down so well.

The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

I'm triaging RTBC issues → . I read the IS and the comments. I didn't find any unanswered questions or other work to do.

I read the MR and all the changes are fine.

The only question I have is how can I check that there are no other "simple conversions"?

Leaving at RTBC.

Thanks for the review. For Kernel tests we had an extra issue for any "miscellaneous" fixes. I think once all fixes in the meta are done we can apply the phpcbf rule and see what's leftover.

@mstrelan, thanks for the explanation.

Committed to 11.x and 10.2.x because of the testing improvement.

Automatically closed - issue fixed for 2 weeks with no activity.

mstrelan → closed merge request !5563