Fix strict type errors: Convert FormattableMarkup to strings (complex replacement) in core Functional tests

Think this should cover everything not in 📌 Fix strict type errors: Convert FormattableMarkup to strings (simple replacement) in core Functional tests RTBC .

To be honest I don't really know when to use string concatenation, string interpolation or sprintf. Most of the time it doesn't seem worth it to add new variables. I've done what seems reasonable to me. The goal is to add the strict_types declaration and I don't think there's much point debating how to format these.

For the goal of getting strict_type added these seem fine.

I also don't know when to use what, and not sure it should be enforced till there is a rule that can be followed. Till then seems to be each person's personal preference, just my observation.

The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

This does not mean that the patch needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

Rebased

Doesn't seem to break anything and still appears to give same strings.

Still fuzzy on when sprintf, formattableMarkup, or double-quotes strings should be used.

I read through the MR and didn't have any questions. I randomly selected a few to test by forcing the error so the message would display. And like @smustgrave, I do see that the changes sometimes uses sprintf and sometimes do not. But that is also personal style and the best fit for the use case. I think this is good to commit and will assign to myself to commit tomorrow.

quietone → closed merge request !6035

Really nice to see FormattableMarkup removed here.

I wanted to commit to 10.2.x to keep the tests in sync but this no longer applies to 10.2.x.

Committed 503192f and pushed to 11.x. Thanks!

Created a new branch from 10.2.x and cherry-picked the same commits. Setting RTBC as it's the same as was committed to 11.x, but let me know if this needs to go to NR first.

@mstrelan, thank you.

Committed 362a5f6 and pushed to 10.2.x to keep tests in sync. Thanks!

quietone → closed merge request !6376

Automatically closed - issue fixed for 2 weeks with no activity.