Convert CheckProvider to use a service locator

Besides a question in the MR about this needing a CR this seems fine to me.

If it _does_ need a CR we might consider doing removing the dynamic_access_check_services parameter in here to prevent a CR on another CR?

Yeah, let's write a change record just in case. Probably need this for the sister issues too...

Unsure about refactoring dynamic_access_check_services here as well, that would probably warrant a separate change record anyway as we are removing a container parameter.

As in the LoggerChannelFactory issue I think we can add BC and point the deprecation notice directly to this issue.

I think we can add BC and point the deprecation notice directly to this issue.

Never seen that before, but hey, you're a Core Committer, so that's probably OK.

The only reason I can think of that it wouldn't be is that phpstan-drupal and drupal rector watch the published CRs automagically to determine if action is needed in either.

But with this:

This service is private and I think the chances of anyone overriding it are low.

I agree chances are pretty low on that.

Re #8 over in 📌 Replace REQUEST_TIME in classes with direct container access Fixed we linked the new $time argument messages directly to the issue, so I assume it's OK to do here as well.

I'm OK with that :)

I also think linking to the issue directly is a reasonable approach where we don't expect anyone to have to make changes and the CR would would have nothing useful to say about the change. Committed/pushed to 11.x, thanks!

Automatically closed - issue fixed for 2 weeks with no activity.