- Issue created by @pdureau
- Issue was unassigned.
- Status changed to Needs review
6 months ago 11:08am 27 February 2024 - Status changed to Needs work
6 months ago 1:59pm 4 March 2024 The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- Status changed to Needs review
6 months ago 2:21pm 4 March 2024 - Status changed to Needs work
6 months ago 8:24pm 10 March 2024 - Status changed to Needs review
6 months ago 8:31am 12 March 2024 - 🇷🇸Serbia finnsky
Fixed feedbacks. About disclaimer component honesty i don't really think it is good component.
1. It used only once.
2. It designed to be used only once.
3. It can be easy replaced with good layout grid and typography.So i don't want to fix it now. But better remove it in future planned Umami improvements.
- Status changed to RTBC
6 months ago 8:45am 12 March 2024 - 🇫🇷France pdureau Paris
Fixed feedbacks.
Not tested with local instance, but looks great in the MR.
About disclaimer component...
As you wish ;)
- {% if label %} + {% if block('label') is defined and block('label')|trim %}
This Twig block thingy is still looking weird to me. I know it is common practice in SDC community, and it is not a hill I am willing to die on. But I guess this practice will fade out of fashion if components calls move from presenter templates to Render API.
- 🇬🇧United Kingdom alexpott 🇪🇺🌍
Committed and pushed 4a2b996bb2 to 11.x and 29de0ae60e to 10.3.x. Thanks!
-
alexpott →
committed 29de0ae6 on 10.3.x
Issue #3414981 by finnsky, pdureau: Umami Demo: review of the already...
-
alexpott →
committed 29de0ae6 on 10.3.x
- Status changed to Fixed
6 months ago 10:24am 14 March 2024 -
alexpott →
committed 4a2b996b on 11.x
Issue #3414981 by finnsky, pdureau: Umami Demo: review of the already...
-
alexpott →
committed 4a2b996b on 11.x
Automatically closed - issue fixed for 2 weeks with no activity.