- Issue created by @AstonVictor
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 1:27pm 11 January 2024 - Status changed to Needs work
over 1 year ago 9:41pm 11 January 2024 - 🇵🇭Philippines paraderojether
Hi AstonVictor,
I reviewed MR!25, and applied against Prevnext 3.0.x-dev with Drupal core version 10.1.7. The MR is applied cleanly but there are still remaining phcpcs shown below:
jetherparadero@PrometSources-MacBook-Pro prevnext % curl https://git.drupalcode.org/project/prevnext/-/merge_requests/25.diff | git apply -v % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 2608 0 2608 0 0 6406 0 --:--:-- --:--:-- --:--:-- 6619 Checking patch prevnext.module... Checking patch src/Plugin/Block/PrevNextBlock.php... Checking patch src/Plugin/views/field/PrevNextLinks.php... Applied patch prevnext.module cleanly. Applied patch src/Plugin/Block/PrevNextBlock.php cleanly. Applied patch src/Plugin/views/field/PrevNextLinks.php cleanly. jetherparadero@PrometSources-MacBook-Pro prevnext % cd .. jetherparadero@PrometSources-MacBook-Pro contrib % phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig prevnext FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/prevnext/README.md ------------------------------------------------------------------------------------------------ FOUND 0 ERRORS AND 5 WARNINGS AFFECTING 5 LINES ------------------------------------------------------------------------------------------------ 3 | WARNING | Line exceeds 80 characters; contains 88 characters 4 | WARNING | Line exceeds 80 characters; contains 100 characters 6 | WARNING | Line exceeds 80 characters; contains 86 characters 11 | WARNING | Line exceeds 80 characters; contains 91 characters 41 | WARNING | Line exceeds 80 characters; contains 86 characters ------------------------------------------------------------------------------------------------ Time: 210ms; Memory: 10MB
Kindly check and advise, please.
Thank you. - Status changed to Needs review
over 1 year ago 5:49am 12 January 2024 - 🇮🇳India viren18febs
I have also getting the same issues after the phpcs , so i have fixed the pending issues and added a patch .
Please review. - Status changed to Needs work
over 1 year ago 5:59am 12 January 2024 - 🇮🇳India ashutosh ahirwal India
I have reviewed the patch provided in #5, it get applied cleanly but still there are some error found by phpcs command.
Command used with arguments to test:-
./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,yml web/modules/custom/prevnextRemaining error:-
FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/prevnext/prevnext.module
-------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------
134 | ERROR | [x] Newline required after opening brace
134 | ERROR | [x] Closing brace must be on a line by itself
-------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/prevnext/src/Plugin/views/field/PrevNextLinks.php
--------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------------
149 | ERROR | [x] Newline required after opening brace
--------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------------FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/prevnext/src/Plugin/Block/PrevNextBlock.php
--------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
--------------------------------------------------------------------------------------------------------------------
143 | ERROR | [x] Newline required after opening brace
173 | WARNING | [ ] Unused variable $entity.
--------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------Time: 346ms; Memory: 10MB
- 🇮🇳India pray_12
Reviewed the patch #5 ,it gets applied cleanly and no errors or warnings were found
- Status changed to Fixed
over 1 year ago 7:20am 12 January 2024 - 🇺🇦Ukraine AstonVictor
README.md file doesn't contain any php code and there is no need to fix it.
patch #5 won't be merged.MR #25 merged. Changes will be added to the next release.
Automatically closed - issue fixed for 2 weeks with no activity.