Deprecate Book module

So our decision to not remove the deprecated modules related CSS in 11.x bites us here.

core/themes/olivero/config/optional/block.block.olivero_book_navigation.yml has a dependency on book, which triggers a deprecation in \Drupal\KernelTests\Config\DefaultConfigTest::testThemeConfig.

Not quite sure what to do here, maybe special case this situation in DefaultConfigTest, either specific for olivero and books, or better in general?

If modules can provide default config for themes, we could move the block over and not the CSS, but... can they even do that??

Yeah dependencies supports thèmes sonth so that should be doable - nice idea!

Ok, so I moved the dependency and block settings over to a optional config yaml in the book module, that didn't break too much, but I like to be sure this is the correct approach before trying to fix the new test-failures.

From looking at a couple of the test failures they look like ones we'd probably have to deal with when we move book out of core - like comparing default config etc. if that's the case then I think it makes sense to do it this way.

Testfailures where due to me not moving the whole block but trying to be clever.
(Trust me, that never works out...)

Straight up move of the block.block.olivero_book_navigation.yml to the book module appeases all tests.

Could a CR be added?

Ah sorry, thought one was already there.
It wasn't, added one.

Thanks! Reviewing this like I did Forum and believe everything has been addressed.

We need a stable release of the contrib module before we can proceed here

Thanks

Contrib module created but one blocker still here

Just committed the blocker.

@pwolanin Now it needs to move code to contrib module according to https://www.drupal.org/about/core/policies/core-change-policies/module-o... →

After that RTBC +1

The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

This still needs a stable release of the contrib module per #16 at https://www.drupal.org/project/book →

Will do one by 10.3 for sure. Think we were waiting for 📌 Add validation constraints to book.settings Needs review and 📌 Update MigratePluginManager to include both attribute and annotation class Fixed to land to avoid multiple subtree splits.

But if we can do the sub-tree split without those and just backport manually without a full sub-tree split we can do a release today.

📌 Add validation constraints to book.settings Needs review may have its own dependencies, so I don't think the book subtree split should wait on it. If it had already gone in, it would have been worth waiting for, but it's still got open questions so might not even land in 10.3.x

📌 Update MigratePluginManager to include both attribute and annotation class Fixed looks a bit closer so might still be worth trying to push that through first.

However we're coming up close to the 10.3 beta deadline, and still need to do module removals and update test fixture changes in the next three to four weeks. I'm not sure if/how many fixtures include book module, but if they do, then it might be better to just go ahead here.

Migrate one just landed so we can do the sub tree split.

A 1.0.0 release has been made for book

Rebased this MR.

I really just rebased this. Work was already done so think I'm good to RTBC.

Reviewed this again, all looks straightforwards. Some core modules I am pleased about deprecating and have been trying to get rid of for years, but I still like and use book module so this is a shame, but it's just not used as much as it was, and there are other options in contrib these days too. I'll need to install the contrib book module for at least one site.

Committed/pushed to 11.x and cherry-picked to 10.3.x, thanks!

Publish CR

Automatically closed - issue fixed for 2 weeks with no activity.

quietone → closed merge request !6697