- Issue created by @joachim namyslo
- π¦πΉAustria Grienauer Vienna
I will try to fine one, tho help us with this issue.
- π§πͺBelgium BramDriesen Belgium π§πͺ
I think this is in the wrong issue queue.
- π§πͺBelgium BramDriesen Belgium π§πͺ
Fixed a few typo's in the IS.
- π©πͺGermany joachim namyslo Kulmbach π©πͺ πͺπΊ
Is it?
I do not know, bewcause I do not know if t() was just forgotton here or that has something to do with the extraction process.
But we'll figure that out.Thanks for moving that issue.
- π§πͺBelgium BramDriesen Belgium π§πͺ
If the strings are not set as translatable it's indeed a core issue.
If it's not showing on l.d.o like the IS is suggesting this should be the right queue π we can always move it back!
- πΊπΈUnited States drumm NY, US
These strings look like they are from https://git.drupalcode.org/project/drupal/-/blob/11.x/core/modules/file/...
You can see 10.2.0 was parsed at https://localize.drupal.org/translate/projects/drupal/releases and the file containing that file was processed without warnings https://localize.drupal.org/translate/projects/drupal/releases/557916#so...
potx module has this, and I do not see something that matches to mark it as translatable:
https://git.drupalcode.org/project/potx/-/blob/7.x-3.x/yaml_translation_... - π¦πΊAustralia larowlan π¦πΊπ.au GMT+10
Fwiw https://git.drupalcode.org/project/drupal/-/blame/11.x/core/lib/Drupal/C... these are declared translatable here
- πͺπΈSpain fjgarlin
I guess that'll make them translatable in each individual site vs having this module detect them without needing to visit the page where they're at. I'm not sure of this though.
I'm going to implement Neil's suggestion.
- Open on Drupal.org βCore: 7.x + Environment: PHP 5.6 & MySQL 5.5last update
over 1 year ago Not currently mergeable. - Open on Drupal.org βCore: 7.x + Environment: PHP 5.6 & MySQL 5.5last update
over 1 year ago Not currently mergeable. - last update
over 1 year ago 18 pass - Status changed to Needs review
over 1 year ago 9:12am 3 January 2024 - πͺπΈSpain fjgarlin
I added the suggestion from #12 in https://git.drupalcode.org/project/potx/-/merge_requests/10/diffs
Not sure how to test this though. Please review.
- π§πͺBelgium BramDriesen Belgium π§πͺ
Change looks simple enough. Will leave it at NR so others can have a look as well.
-
GΓ‘bor Hojtsy β
committed 46e7fc79 on 7.x-3.x authored by
fjgarlin β
Issue #3411529 by fjgarlin, Joachim Namyslo, BramDriesen, drumm,...
-
GΓ‘bor Hojtsy β
committed 46e7fc79 on 7.x-3.x authored by
fjgarlin β
- Status changed to Downport
over 1 year ago 2:47pm 4 January 2024 - ππΊHungary GΓ‘bor Hojtsy Hungary
Merged to Drupal 7. We need a Drupal 8 port of this as well for the Drupal 8 branch, thanks!
- last update
over 1 year ago 18 pass - Status changed to Needs review
over 1 year ago 3:15pm 4 January 2024 - π§πͺBelgium BramDriesen Belgium π§πͺ
I *think* I did this correctly on the existing issue fork π
-
GΓ‘bor Hojtsy β
committed ec723861 on 8.x-1.x authored by
BramDriesen β
Issue #3411529 by fjgarlin, BramDriesen, GΓ‘bor Hojtsy, Joachim Namyslo,...
-
GΓ‘bor Hojtsy β
committed ec723861 on 8.x-1.x authored by
BramDriesen β
- Status changed to Fixed
over 1 year ago 3:47pm 4 January 2024 - πΊπΈUnited States drumm NY, US
Deployed and this is ready to translate: https://localize.drupal.org/translate/languages/de/translate?sid=2983012
- π©πͺGermany joachim namyslo Kulmbach π©πͺ πͺπΊ
Thank you all.
That was really quick.
Some parts of this page are still not translateable see: #3412541
Automatically closed - issue fixed for 2 weeks with no activity.