Deprecate system.performance stale_file_threshold

Something like this.

LInk to the report & discussion on Slack where this has been discussed and occured first time reported: https://drupal.slack.com/archives/C1BMUQ9U6/p1703153827992839

In the previous mentioned discussion following system.performance keys have been error reported on screen while saving admin performance cache settings:

cache:
  page:
    use_internal: false

response:
  ...

stale_file_threshold: '172800'

So, follow up readers who need to fix that manually for now: check your system.performance config by running drush cget system.performance In case you find obosolete left-over keys (read Wim's and my notes and links in the Slack chat above), in my case like cache: page: use_internal or stale_file_threshold and response you can remove them with drush cdel system.performance cache.page.use_internal or drush cdel system.performance stale_file_threshold etc. (note the dot to target sub ordinated keys)

Not sure what's suppose to be reviewed.

Can the issue summary be completed. If something is deprecated is the CR attached to another ticket?

@smustgrave the CR is attached to 📌 Remove the aggregate stale file threshold and state entry Fixed , what's deprecated is the config schema key.

Thanks in that case LGTM.

larowlan → credited Wim Leers → .

Issue credits

larowlan → closed merge request !5918

Committed to 11.x and backported to 10.2.x

Nice work all 💪

Automatically closed - issue fixed for 2 weeks with no activity.