Remove statistics module from comments

Let me work on this.

@sourabhjain, when you work on an issue it is good practice to comment on what you did and what still remains to be done. By the MR I can see that you did the first item in the 'remaining tasks' but did you do the second step?

I am going to set this to needs review. I have not searched for other instances.

Do not believe a search was done.

Did a phpstorm search and manually reviewed the findings

Y2038TimestampUpdateTest as reference to statistics module that could be removed

But think it would be good to postpone this on moving statistics tests as a lot of comments seems to be attached to tests, example in commentStatistics.

Ignored findings in Forum

This the reference in Y2038TimestampUpdateTest

      // Start with a standard install of Drupal 9.3.0 with the following
      // enabled modules: forum, language, locale, statistics and tracker.
      DRUPAL_ROOT . '/core/modules/system/tests/fixtures/update/drupal-9.4.0.filled.standard.php.gz',
      DRUPAL_ROOT . '/core/modules/system/tests/fixtures/update/Y2038-timestamp.php',

The reference to statistics there can stay because it actually is installed in drupal-9.4.0.filled.standard.php.gz.

And the changes to htaccess breaks tests.

Looking for how to remove statistics and have the tests pass

Removed the work on the htaccess and tests to a sibling issue.

Ready for review

All changes look sensible, did a search, most references that came up are for fixtures and migrations, htaccess is a separate issue.

I believe this is the last straggler that we overlooked?
We caught it in the actual autoload.php, just not in the generator of the file: https://git.drupalcode.org/project/drupal/-/blob/11.x/composer/Plugin/Sc...

@Spokje, Thank you for finding a straggler!

Thanks @quietone, I would RTBC this, but I see @sourabh_jain_419 left a comment on the MR.

Not sure why composer/Plugin/Scaffold/GenerateAutoloadReferenceFile.php shouldn't be changed?

Added an explanation in the MR why I think it _should_ be changed.

Marking as RTBC to let core committers decide on it.

larowlan → credited catch → .

Committed to 11.x, thanks

larowlan → closed merge request !5931

Automatically closed - issue fixed for 2 weeks with no activity.