[regression] toUrl can incorrectly return edit-form url when another link template shares the canonical url

Failed as expected https://git.drupalcode.org/issue/drupal-3409895/-/pipelines/66112/test_r...

So swapping to intersecting by key works, although it still feels a bit icky to me. It would be nice to have a triple null coalescing but I don't think that's possible.

Added a simpler suggestion.

media uses that for canonical/edit as well FWIW.

latest and canonical on the same is a bit weird though I think, what does that even mean? You can't access the default revision anymore if there's a draft? what happens if you don't have access to view that?

latest and canonical on the same is a bit weird though I think, what does that even mean?

True it's weird, but for this particular entity type that's how we wanted it. It means the View route shows the latest revision. Revision access isn't an issue in this scenario and you can access the default revision via the revision view route :)

1) Drupal\Tests\Core\Entity\EntityUrlTest::testToUrlDefaultFallback
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'entity.test_entity.canonical'
+'entity.test_entity.edit_form'
/builds/issue/drupal-3409895/vendor/phpunit/phpunit/src/Framework/Constraint/Equality/IsEqual.php:94
/builds/issue/drupal-3409895/core/tests/Drupal/Tests/Core/Entity/EntityUrlTest.php:515
/builds/issue/drupal-3409895/core/tests/Drupal/Tests/Core/Entity/EntityUrlTest.php:155
/builds/issue/drupal-3409895/vendor/phpunit/phpunit/src/Framework/TestResult.php:728
/builds/issue/drupal-3409895/vendor/phpunit/phpunit/src/Framework/TestSuite.php:684
/builds/issue/drupal-3409895/vendor/phpunit/phpunit/src/TextUI/TestRunner.php:651
/builds/issue/drupal-3409895/vendor/phpunit/phpunit/src/TextUI/Command.php:144
/builds/issue/drupal-3409895/vendor/phpunit/phpunit/src/TextUI/Command.php:97
FAILURES!
Tests: 22, Assertions: 98, Failures: 1.

Additional test coverage seems to be there.

Change makes sense and know from the block_content module uses the same as media. Working on adding that setting to use standalone URLs too, but a separate issue.

This seems reasonable. Committed/pushed to 11.x and cherry-picked to 10.2.x, thanks!

Wow, just saw this. Sorry for introducing this! I can only speculate as to what lead to me use that indirection, but absolutely agreed that it's much more readable now, thanks! And this will (hopefully) teach me to more carefully consider the consequences of array_flip() in the future. In any case, great to see this fixed, thanks again!

acbramley → closed merge request !5888

Automatically closed - issue fixed for 2 weeks with no activity.