Add support for automatically wiring dependencies without implementing ContainerInjectionInterface

chesn0k → changed the visibility of the branch 3409787-add-support-for to hidden.

chesn0k → changed the visibility of the branch 3409787-add-support-for to active.

Thanks for posting the MR.

Will need test coverage to ensure nothing breaks it in the future.

Thanks! Change looks good to me but probably need to get reviewed by those more failure with the auto-wiring.

This looks like a nice feature but I think we should reuse (or refactor) AutowireTrait here if we can.

Also, taking another look at the code, I noticed that there is no support for the union and intersection types. Should I put this in a separate issue?

What do you suggest instead of the trait? A service specifically for handling autowiring?

Yes, please open a new issue for union/intersection types. I can see a use for union types, not sure about intersection types.

service specifically for handling autowiring

Good option, although I thought that this was the responsibility of the class resolver.

Plugins should also be autowireable, see 📌 Allow plugin service wiring via constructor parameter attributes Needs work , hopefully we can unify some of the code there as well?

Plugins should also be autowireable, see #3294266: Allow plugin service wiring via constructor parameter attributes, hopefully we can unify some of the code there as well?

Yes, this seems like a good reason to move autowire into a separate service.

This should also mean we can drop AutowireTrait from ControllerBase?

Yes.

And so the current implementation of autowiring allows create a plugin instance in this way:

$instance = \Drupal::service(DependencyAutowire::class)->autowireClass(
  new \ReflectionClass($plugin_class),
  [
    'configuration' => $configuration,
    'plugin_id' => $plugin_id,
    'plugin_definition' => $plugin_definition,
  ],
);

Plugin __construct:

public function __construct(
  array $configuration,
  string $plugin_id,
  array $plugin_definition,
  protected readonly RouteMatchInterface $routeMatch,
) {
  parent::__construct($configuration, $plugin_id, $plugin_definition);
}

This is not bad, but I think the __construct method signature is too strict, plugins that not required to extends the base plugin could use property promotion:

public function __construct(
  protected array $configuration,
  protected string $pluginId,
  protected array $pluginDefinition,
  protected readonly RouteMatchInterface $routeMatch,
) {}

I think we should search for arguments using snake_case and camelCase styles this can be implemented inside the dependency autowiring service.

Also should I remove all uses of AutowireTrait in current branch and mark as deprecated?

The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.