- Issue created by @Spokje
- Merge request !5749Resolve #3407211 "Update stylelint config standard to" β (Open) created by Spokje
- Status changed to Needs review
9 months ago 3:52pm 9 December 2023 - π³π±Netherlands Spokje
So the current state of the MR uses
stylelint-junit-formatter
.
I also opened https://gitlab.com/leon0399/stylelint-formatter-gitlab/-/issues/3 to try and getstylelint-formatter-gitlab
working withstylelint
16 and upwards.Putting this on NR the get some input on:
- if we want to try and get this into 10.2.0
- if so, are we prepared to (temporarily) fallback to usingstylelint-junit-formatter
and going back to test-errors instead of codequality. - πΊπΈUnited States smustgrave
The rules being removed does prettier automatically catch those now?
- π³π±Netherlands Spokje
The rules being removed does prettier automatically catch those now?
Not quite, but good question.
-
stylelint
has loads of rules, but enables none of them by default.
-stylelint-config-standard
enables a bunch of them with some community-defined, sane defaultsDrupal uses a lot of those
stylelint-config-standard
rules, but overrules some of them with other defaults, and disables others.The latter one is of interest here. When there's a
"[rule-name]": null
defined incore/.stylelintrc.json
, it _should_ meanstylelint-config-standard
-enabled rule, Drupal turns it off. (More on the _should_ below).The rules that are removed in this issue (
function-whitespace-after
andmax-line-length
), were both defined as null, so were turned off in Drupal, so no need for replacement.Now to the _should_: Turns out during all updates of
stylelint
andstylelint-config-standard
we didn't pay much attention to rules that were dropped at some point fromstylelint-config-standard
but still being turned off in ourcore/.stylelintrc.json
.
Turning things off that aren't on in the first place is just silly.Opened [#] to get
core/.stylelintrc.json
,stylelint
andstylelint-config-standard
back into sync. - Status changed to RTBC
9 months ago 1:54pm 12 December 2023 - Status changed to Postponed
9 months ago 2:07pm 12 December 2023 - π¬π§United Kingdom longwave UK
Thank you for explaining the changes in #10.
As this breaks our current CI integration because
stylelint-formatter-gitlab
is not yet compatible, I think we should hold off on committing this for a while - there are no pressing changes here and to me this can wait until 10.3.