- Issue created by @bbrala
- 🇳🇱Netherlands bbrala Netherlands
Posponed on 📌 Configure GitLabCI matrix testing Active
- 🇳🇱Netherlands bbrala Netherlands
Remove phpstan step since @longwave and @catch decided we can wait on that until we see real reason to.
- Assigned to bbrala
- Open on Drupal.org →Environment: PHP 8.2 & MySQL 8last update
10 months ago Not currently mergeable. - @bbrala opened merge request.
- last update
10 months ago Custom Commands Failed - last update
10 months ago Custom Commands Failed - last update
10 months ago 30,158 pass - last update
10 months ago 30,158 pass - last update
10 months ago 30,158 pass 40:13 2:50 Running- Status changed to Needs review
10 months ago 2:53pm 15 September 2023 - 🇳🇱Netherlands bbrala Netherlands
I've moved the lint stept to the parent pipeline. Things should be linted before we start child jobs.
There are no lint jobs in the child jobs anymore. But we do have an extra composer/yarn run now in the parent job. But i think that is a good tradeoff.
Not sure how to completely test this. Will add a new branch with errors from ✨ Integrate codequality reports into Gitlab RTBC to proove failure.
- last update
10 months ago Custom Commands Failed - @bbrala opened merge request.
- Open on Drupal.org →Environment: PHP 8.2 & MySQL 8
9:34 9:34 Queueing - last update
10 months ago 30,158 pass - last update
10 months ago 30,158 pass - last update
10 months ago 30,158 pass - last update
10 months ago 30,158 pass - Status changed to RTBC
10 months ago 7:03pm 15 September 2023 - 🇬🇧United Kingdom catch
Looks great when it's not messed up by me...
Will commit Monday if no further feedback by then to unblock the next steps.
- Status changed to Fixed
10 months ago 9:09am 16 September 2023 - 🇬🇧United Kingdom catch
Committed/pushed to 11.x and cherry-picked to 10.1.x, thanks!
- 🇬🇧United Kingdom catch
Wondering what it would look like if we moved the default environment test runs into the main job too, and only used child jobs for non-default environments. It would block non-default environments on a default-environment pass, and mean the common case of an MR pipeline running against the default wouldn't need the double build step. However no idea how to structure this cleanly in the YAML, and it would have other issues like having to wait for MySQL if you're actually testing a postgres bug.
Automatically closed - issue fixed for 2 weeks with no activity.