Fix strict type errors in Functional tests: Add casts and fix types where needed

I'm triaging RTBC issues → . I read the IS and the comments. I didn't find any unanswered questions.

I read the MR and left some questions.

Rebased and addressed feedback.

Feedback and follow up appear to be addressed.

Yet another rebase. TaxonomyTermFilterDepthTest has moved to a Kernel test so those fixes will need to be made in 📌 Fix strict type errors: miscellaneous fixes in core Kernel tests Postponed .

There are a lot of tickets in NR and RTBC of converting functional tests to kernel so this may be hitting a moving target

Rebase seems fine

MR no longer applies

$ curl -s https://git.drupalcode.org/project/drupal/-/merge_requests/5564.diff | git apply
error: core/modules/node/tests/src/Functional/Views/PathPluginTest.php: No such file or directory
error: core/modules/node/tests/src/Functional/Views/RowPluginTest.php: No such file or directory

Rebased and reverted changes to the now kernel tests mentioned in #11. Noted in #3402713-8: Fix strict type errors: miscellaneous fixes in core Kernel tests → for these to be fixed there.

Since just a rebase, going to restore status.

Sorry, found a few more in MR !6377 which I opened to make sure we have caught all the errors. Back to NR for the last 4 commits.

Reviewed the additional 4 and don't see any issue.

I think we should postpone this on 🐛 Incorrect typehint of LOGGED_IN and LOGGED_OUT consts in UserAuthenticationController Needs work so we don't need the extra casts here.

I think rather than postponing we can just drop those changes from this issue (which I've done). This will inherently postpone 📌 Add declare(strict_types=1) to all Functional tests Fixed instead, which is already postponed until all the tests pass. Setting this back to NR since I've reverted these changes.

Restoring status with that part removed.

Committed to 11.x, flagging for backport. As we're not changing the phpcs rules in 10.2.x it probably won't matter that we didn't backport 🐛 Incorrect typehint of LOGGED_IN and LOGGED_OUT consts in UserAuthenticationController Needs work

larowlan → closed merge request !5564

I've pushed a 10.2.x branch and dropped the last commit that was reverting changes to UserLoginHttpTest. Even though we're not changing the phpcs rule, presumably we would still backport the strict types declaration, so the test would throw an error. I think casting the ints in 10.2.x is the right approach.

10.2 update seems good.

I read the MR, looking for the changes related to 🐛 Incorrect typehint of LOGGED_IN and LOGGED_OUT consts in UserAuthenticationController Needs work and I see the correct changes have been made. I had some time so I also did some extra checking. I made a patch from the commit on 11.x and compared that to the diff here for 10.2.x. The diff confirmed that the changes are only in \Drupal\Tests\user\Functional\UserLoginHttpTest and are adding a cast to string on lines like this.
$this->assertHttpResponse($response, 200, (string) UserAuthenticationController::LOGGED_IN);

Committed 02c2f2c and pushed to 10.2.x. Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.