Add declare(strict_types=1) to all Functional tests

mstrelan → changed the visibility of the branch 3399746-strict-types-functional-fix to hidden.

The only remaining issue before this can be merged is 📌 Fix strict type errors in WebAssert calls Needs review .

Agreed with @mstrelan that although we tried to fix all strict errors in 📌 Fix strict type errors in WebAssert calls Needs review one more has snuck in since; as it's only one instance the most pragmatic way to continue is just to apply that fix directly as part of this issue.

Confirmed that the IS is correct, the MR only contains strict_types changes plus the 2 commits mentioned + the phpcs.xml.dist change (using git diff --color-words 11.x | grep -v declare\(strict_types and scanning the output)

The line number changes make sense as we are adding 2 lines to those files.

These changes are the new fixes discussed above.

This is ready to go, nice!

Committed and pushed to 11.x and 10.3.x, thanks!

PHPStan crashed locally when running against this change via commit-code-check.sh with lots of "error code 127", unsure if there were too many changes for it to handle in one go?

longwave → closed merge request !5510

Automatically closed - issue fixed for 2 weeks with no activity.