- Issue created by @mstrelan
- Status changed to Needs review
10 months ago 6:21am 20 November 2023 - Status changed to RTBC
10 months ago 12:57pm 20 November 2023 - Status changed to Needs review
9 months ago 10:40pm 30 November 2023 - 🇺🇸United States dww
Only hesitation is I wonder if we should wait until everything else is committed before we commit this one, just in case something else slips through before we're ready to turn on strict types. Maybe postponed is better for right now, and we move to RTBC later?
- 🇺🇸United States dww
To be explicit: I reviewed the MR and agree this is RTBC, I'm only wondering on the ordering/timing.
- Status changed to Postponed
9 months ago 10:43pm 30 November 2023 - 🇦🇺Australia mstrelan
Need to migrate changes mentioned in [#3404508:11] to this issue.
- Status changed to Needs review
5 months ago 12:46pm 9 April 2024 - 🇦🇺Australia mstrelan
This is unblocked now. The MR at https://git.drupalcode.org/project/drupal/-/merge_requests/6826 demonstrates that adding these fixes and declaring strict types everywhere results in a green pipeline. So if we get this in we can update 📌 [PP-2] Add declare(strict_types=1) to all Kernel tests Postponed and get that in also.
- Status changed to RTBC
5 months ago 5:26pm 9 April 2024 - 🇺🇸United States smustgrave
Looking at the MR in #9 see the change here doesn't break anything and allows for adding strict type.
- 🇬🇧United Kingdom alexpott 🇪🇺🌍
-
alexpott →
committed cb25ccbb on 10.2.x
Issue #3402713 by mstrelan, smustgrave, dww: Fix strict type errors:...
-
alexpott →
committed cb25ccbb on 10.2.x
-
alexpott →
committed 8331ba7e on 10.3.x
Issue #3402713 by mstrelan, smustgrave, dww: Fix strict type errors:...
-
alexpott →
committed 8331ba7e on 10.3.x
- Status changed to Fixed
5 months ago 10:23pm 9 April 2024 -
alexpott →
committed f60bcea7 on 11.x
Issue #3402713 by mstrelan, smustgrave, dww: Fix strict type errors:...
-
alexpott →
committed f60bcea7 on 11.x
Automatically closed - issue fixed for 2 weeks with no activity.