Add declare(strict_types=1) to all Kernel tests

Also postponing on 🐛 Spell-checking job fails with "Argument list too long" when too many files are changed Active .

Since this is the last of the test types to have strict types enabled we can loosen the phpcs pattern.

Before:

<include-pattern>*/tests/src/Functional/*</include-pattern>
<include-pattern>*/tests/src/FunctionalJavascript/*</include-pattern>
<include-pattern>*/tests/src/Kernel/*</include-pattern>
<include-pattern>*/tests/src/Traits/*</include-pattern>
<include-pattern>*/tests/src/Unit/*</include-pattern>

After:

<include-pattern>*/tests/src/*</include-pattern>

Note that since 📌 Fix strict type errors in AssertContentTrait Needs work is still outstanding we need to exclude that one file. I think it's better to get this in sooner while this is green rather than waiting to resolve that one remaining issue. Adding the following:

<!-- @todo remove this in https://www.drupal.org/project/drupal/issues/3402707 -->
<exclude-pattern>./tests/Drupal/KernelTests/AssertContentTrait.php</exclude-pattern>

Can agree with the decision in #6 about getting this in soon to avoid conflicts

This , <include-pattern>*/tests/src/*</include-pattern>, is nice to see.

I do like the idea of not waiting on 📌 Fix strict type errors in AssertContentTrait Needs work . I have not reviewed the MR.

I didn't mean to change the status.

Committed ce1fa38 and pushed to 11.x. Thanks!
Committed 442b471 and pushed to 10.3.x. Thanks!

Backported to 10.3.x by applying the MR and running phpcbf and running all of the changed tests.

Automatically closed - issue fixed for 2 weeks with no activity.

mstrelan → closed merge request !5402