- Issue created by @Kingdutch
- Merge request !5508Issue #3403491: Rename EntityReferenceTestTrait breaks multi-version testing → (Open) created by Kingdutch
- Issue was unassigned.
- Status changed to Needs review
10 months ago 8:07pm 22 November 2023 - 🇳🇱Netherlands Kingdutch
MR with the proposed fix created for 10.2.x. Depending on the maintainer decision we may want to apply the same patch to 11.x
- 🇳🇱Netherlands Kingdutch
Marking as critical per longwave since this breaks contrib.
- Status changed to RTBC
10 months ago 8:43pm 22 November 2023 - 🇨🇭Switzerland Berdir Switzerland
11.x is essentially just the current main branch, it is not D11 (yet), so should definitely be applied there too.
I think we can skip the test for the BC layer, we could in theory override the method and trigger a deprecation message and have a test for that and what not, but I think this is simple enough that this isn't required.
Would be useful to test against some of the failing contrib tests manually, but looks straight forward to me.
- Status changed to Needs work
10 months ago 10:09pm 22 November 2023 - 🇬🇧United Kingdom longwave UK
We should add
@trigger_error
to the top of the file so users are notified as soon as the old trait is autoloaded.See
\Drupal\database_statement_monitoring_test\LoggedStatementsTrait
for a similar example. - 🇬🇧United Kingdom longwave UK
Crediting @mglaman for raising this in Slack and the parent issue.
- First commit to issue fork.
- Status changed to Needs review
10 months ago 6:07am 23 November 2023 - 🇮🇳India ankithashetty Karnataka, India
Addressed #6 and rebased the MR.
Thanks! - 🇳🇿New Zealand quietone New Zealand
Adding for completeness that there is policy for deprecating a Trait → .
- Status changed to RTBC
10 months ago 8:41am 23 November 2023 - 🇧🇪Belgium BramDriesen Belgium 🇧🇪
Checked the MR and this looks good! Also fixed a typo in the changelog.
- Status changed to Needs work
10 months ago 8:44am 23 November 2023 - 🇧🇪Belgium BramDriesen Belgium 🇧🇪
Actually the @trigger_error is not following the policy.
- Status changed to Needs review
10 months ago 8:51am 23 November 2023 - Status changed to RTBC
10 months ago 2:44pm 23 November 2023 - 🇺🇸United States smustgrave
Since this is a critical I hope it can still make the 10.2 window.
-
longwave →
committed 7a51238b on 10.2.x
Issue #3403491 by Kingdutch, ankithashetty, BramDriesen, longwave,...
-
longwave →
committed 7a51238b on 10.2.x
-
longwave →
committed 2f071240 on 11.x
Issue #3403491 by Kingdutch, ankithashetty, BramDriesen, longwave,...
-
longwave →
committed 2f071240 on 11.x
- Status changed to Fixed
10 months ago 6:33pm 23 November 2023 - 🇬🇧United Kingdom longwave UK
Yes, as a regression in contrib tests this is eligible for fixing before 10.2.0.
Committed and pushed 2f0712409a to 11.x and 7a51238b2f to 10.2.x. Thanks!
Automatically closed - issue fixed for 2 weeks with no activity.