Rename EntityReferenceTestTrait breaks multi-version testing

MR with the proposed fix created for 10.2.x. Depending on the maintainer decision we may want to apply the same patch to 11.x

Marking as critical per longwave since this breaks contrib.

11.x is essentially just the current main branch, it is not D11 (yet), so should definitely be applied there too.

I think we can skip the test for the BC layer, we could in theory override the method and trigger a deprecation message and have a test for that and what not, but I think this is simple enough that this isn't required.

Would be useful to test against some of the failing contrib tests manually, but looks straight forward to me.

We should add @trigger_error to the top of the file so users are notified as soon as the old trait is autoloaded.

See \Drupal\database_statement_monitoring_test\LoggedStatementsTrait for a similar example.

longwave → credited mglaman → .

Crediting @mglaman for raising this in Slack and the parent issue.

Addressed #6 and rebased the MR.
Thanks!

Adding for completeness that there is policy for deprecating a Trait → .

Checked the MR and this looks good! Also fixed a typo in the changelog.

Actually the @trigger_error is not following the policy.

Since this is a critical I hope it can still make the 10.2 window.

Yes, as a regression in contrib tests this is eligible for fixing before 10.2.0.

Committed and pushed 2f0712409a to 11.x and 7a51238b2f to 10.2.x. Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.