Create a constant for root term ID

Working on it.

I didn't change it in any tests though. Maybe we should continue to verify a hard-corded '0' in the tests. Opinions? Suggestions?

Think if we are going to add a constant we should use it in the tests also.

I've updated the tests to use TermInterface::ID_ROOT. Additionally, I found some more instances of "0", which I've replaced.

Just in OverviewTerms.php there seem to be 6 places the constant could be used.

MR updated with relevant changes, please review.

Thanks!

@ankithashetty thanks but this was assigned to another user just fyi.

My apologies. I kind of missed it. Will make sure to check that next time.✌🏼

Believe instances have been addressed, left a question for the committer.

hanks for working on improving Drupal core.

The issue summary here should explain the problem being solved. This needs an issue summary update to add that and to provide links to the relevant comments in the other issue. Remember, that not all reviewers or committers will be familiar with the originating issue. Let's make an issue inviting for reviewers and committers. Issue summaries do matter. →

Thanks.

IS seems to have been updated.

@ankithashetty, thanks for updating the Issue Summary. It is much easier to understand and thus inviting for a reviewer.

The diff no longer applies, this needs to be rebased locally.

I do think this needs a different name for the constant, as stated in the MR. Ideas?

How can we be sure that all test instances have been changed? What can I do as a reviewer to be sure? For example, I did a little digging and found there is a method \Drupal\Tests\taxonomy\Functional\TermTest::getParentTids that refers top 0 and not the new constant. Nor, have the usages of that method been changed to use the new constant.

Setting to NW for the above.

The constant name 'TERM_ROOT_ID' can be misleading as it might be interpreted as the ID for the root term itself.

However, the constant actually holds the ID for the parent of the root term.
It would be more accurate to name the constant something like "ROOT_TERM_PARENT_ID."

I have identified other scenarios where this constant needs to be used, and I am currently working on it.

I have renamed ID_ROOT to ROOT_TERM_ID and updated few more places with new constant.

I see parent term id hardcoded in many test files. Do we need to replace those test files?

Believe we should use the constant in tests also.

Updated remaining files with the constant ROOT_TERM_ID.

Believe test replacements have been completed.

The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

Rebased, conflicts were resolved carefully. However it needs review again.

Seems to have check errors