Contrib.social

Form actions break for global search fields (v1.5)

Open on Drupal.org →
Created on 17 November 2023, 12 months ago
Updated 3 January 2024, 11 months ago

Problem/Motivation

Since updating to version 1.5 we found that the global search input action fields were being modified by facets pretty paths. The facets_pretty_paths_form_views_exposed_form_alter function in the module file seems to modify the action in this way which then causes the search functionality to not work except when the user is on the search results page.

Steps to reproduce

If you have a site with a global exposed form for search you should see that versions 1.5 and 2 of facets pretty paths causes the action of the form to be replaced thus breaking the search functionality.

Proposed resolution

I propose that we remove the newly added facets_pretty_paths_form_views_exposed_form_alter function from the module file. If there is some functionality that is still required that will not have this adverse effect the community is welcome to improve the function and post patches here so that we can get a balanced solution. A patch will follow promptly in the comments.

Remaining tasks

Review the patch, possibly provide further improvements on the solution and testing by the community.

🐛 Bug report
Status

Fixed

Version

1.5

Component

Code

Created by

🇳🇱Netherlands roaldnel

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024