- Issue created by @BramDriesen
- Merge request !5407feat: Enable Announcements Feed module by default → (Open) created by BramDriesen
- Status changed to Needs review
10 months ago 9:52am 15 November 2023 - Status changed to Needs work
10 months ago 2:44pm 15 November 2023 - Status changed to Needs review
10 months ago 2:56pm 15 November 2023 - Status changed to RTBC
10 months ago 3:15pm 15 November 2023 - 🇺🇸United States xjm
I don't think this needs product or framework manager review. (Also why were release managers left out. 😛) What we actually need is subsystem maintainer review for Umami -- which @markconroy's comment above counts for. So adding credit for that as a subsystem maintainer signoff even though normally such a comment would not be credited.
This seems fine to me; however, as I recall, Umami adds things only once they're stable. So we actually need the other issue to go in first, which means this should be postponed on it. Thanks!
- Status changed to Postponed
10 months ago 11:12pm 15 November 2023 - Status changed to RTBC
10 months ago 9:04am 16 November 2023 - 🇧🇪Belgium BramDriesen Belgium 🇧🇪
Also why were release managers left out.
Because I don't know the proper rules of tagging 🤣
Umami adds things only once they're stable.
Yup, was aware of that, but I guess they can follow up close on each other since this is only a minor change.
- Status changed to Postponed
10 months ago 9:04am 16 November 2023 - 🇧🇪Belgium BramDriesen Belgium 🇧🇪
I don't understand why that just happened as I didn't touch the issue metadata, setting back...
- Status changed to RTBC
10 months ago 7:47am 20 November 2023 - 🇧🇪Belgium BramDriesen Belgium 🇧🇪
Setting back to RTBC as 📌 Mark Announcements Feed as stable Fixed got merged!
- Status changed to Needs review
10 months ago 8:04am 20 November 2023 - 🇫🇮Finland lauriii Finland
Hmm, this doesn't play nicely on some screen sizes because Umami has the additional message. It seems that there's less value in community announcements in the Umami install profile since it's supposed to be the demo experience, so maybe we should not install it at least without making sure that it plays nicely with the Toolbar.
- 🇧🇪Belgium BramDriesen Belgium 🇧🇪
I'll check if this can be fixed by changing the weight of the menu item.
- 🇧🇪Belgium BramDriesen Belgium 🇧🇪
If we can place the message behind the announcements feed, I think the issue is solved because the message wraps to the next line.
- 🇧🇪Belgium BramDriesen Belgium 🇧🇪
Changed the weight to be 1 higher as what the announcements feed is at.
- Status changed to RTBC
10 months ago 1:50pm 20 November 2023 - 🇺🇸United States smustgrave
Applied the MR and got the same results as #18
-
longwave →
committed 2ec2791a on 10.2.x
Issue #3401802 by BramDriesen, lauriii, smustgrave, xjm, markconroy: Add...
-
longwave →
committed 2ec2791a on 10.2.x
-
longwave →
committed 8d47e6f0 on 11.x
Issue #3401802 by BramDriesen, lauriii, smustgrave, xjm, markconroy: Add...
-
longwave →
committed 8d47e6f0 on 11.x
- Status changed to Fixed
10 months ago 11:18am 25 November 2023 - 🇬🇧United Kingdom longwave UK
Changes to Umami can be made at any time, so this is eligible in the beta phase for 10.2.
Committed and pushed 8d47e6f036 to 11.x and 2ec2791a59 to 10.2.x. Thanks!
Automatically closed - issue fixed for 2 weeks with no activity.