External fonts cannot be loaded via add_css ajax command

Okay, so I committed only to test without the fix. As you can see test failed.

Okay, with the fix tests are green. I tried to run 🩹 Test-only changes but could not, it didn't even run. I'm not sure how to use it properly, maybe it's broken for now. Anyway, the issue is ready for review.

Ah, and since this bug can lead to missing content on the site, I'm changing the status of this one to critical. In our case comment form was not rendered at all, only the big_pipe placeholder was in place. This is because we added Google fonts into ckeditor5-stylesheet like here in core

This happens to me also, the patch resolves the problem.

I rebase the MR and run Test-only changes but it's failing because changes in core/modules/system/tests/modules/ajax_test are discarded by the job.

umm can we have the test use an ajax command instead of bigpipe? seems wrong to have a dependency on that module for all the command tests.

I'd expect to have some more code around this, not a whole new method

    // Tests the 'add_css' command.
    $page->pressButton("AJAX 'add_css' command");
    $this->assertWaitPageContains('my/file.css');

Ah, I was hoping that no one would notice :). I have no time to implement a proper test now that's why I made a PoC with big_pipe. If someone can, please make a proper test.

I created a separate MR without big_pipe for test.

Looks good to me.

Can you replace the domain but keep the rest of the URL intact please? also in the test no need to test for the whole link tag.

So just like it was before, and replacing the google domain with example.com

Added back query param

I find it odd not to test the whole link tag without the closing tag

    $this->assertWaitPageContains('<link rel="stylesheet" href="https://example.com/css?family=Open+Sans"');

I removed the media attribute instead so the test is like this

    $this->assertWaitPageContains('<link rel="stylesheet" href="https://example.com/css?family=Open+Sans">');

We had the same issue in a project.
Can confirm that MR changes resolve it. And tests correctly identify an issue.

Since @nod_ already took a look and all threads on MR seem to be resolved, moving to RTBC.

alexpott → changed the visibility of the branch 3400359-external-fonts-cannot to hidden.

I think we need to adjust the test slightly. ONce that's done an passing this can be set to rtbc again.

Restoring status, as this was marked critical.

Committed 6249892 and pushed to 11.x. Thanks!

backported to 10.2.x

Automatically closed - issue fixed for 2 weeks with no activity.