Allow all callables in ConfigTarget

very cool!

Could we revert the r/rw => 0/1 conversion ?

I think it would serve as a neat example.

I've addressed @bircher and @andypost's reviews. This is ready for another round.

alexpott → credited andypost → .

This is a very useful changes and the change itself looks very readable as well, what I don't understand is that we disallowed callables before because of serialisation.

This is the old comment, is that no longer true?

 If these could be arrays, then they could be
    // in the form of [$object, 'method'], which would break serialization if
    // $object was not serializable. This is also why we don't type hint these
    // parameters as ?callable, since that would allow closures (which can't
    // be serialized).

#4++

#8: That is indeed no longer true. See the ::fromForm() method that @alexpott introduced. I left a comment about it on the MR that may be helpful in understanding it.

Just left a few nits/questions, but this is 90% ready IMHO.

Addressed all review points.

AFAICT

      2x: Creation of dynamic property
    Drupal\Core\Form\ConfigTarget::$elementName is deprecated

is causing the test failures.

But I see no more occurence? 😳 WTF!

EDIT: LOL, @alexpott just pushed the fix at https://git.drupalcode.org/project/drupal/-/merge_requests/5251/diffs?co... — that's why 🤣

This looks like an excellent improvement! 👍

Very nice. Had to have a couple of read throughs to figure out what was going on, but very nifty. Committed/pushed to 11.x and cherry-picked to 10.2.x, thanks!

I've updated https://www.drupal.org/node/3373502 →

Automatically closed - issue fixed for 2 weeks with no activity.

It looks like this may have caused the \Drupal\Core\Form\ConfigTarget to not be fully serializable: 🐛 \Drupal\Core\Form\ConfigTarget is not fully serializable Active .