- Issue created by @SamLerner
- Status changed to Needs review
about 1 year ago 9:02pm 3 November 2023 - Status changed to Needs work
about 1 year ago 12:29am 4 November 2023 - 🇺🇸United States smustgrave
Think such a change will require test coverage.
Would recommend an MR as patches are phased out and don't auto run the tests anymore. I'll trigger though.
- last update
about 1 year ago 30,483 pass, 2 fail - 🇺🇸United States SamLerner
Yes, I was admittedly being lazy by attaching a patch. :) but now I'll make an MR so I can add tests.
- Merge request !5301Reorder configuration name dropdown by ID instead of label. → (Open) created by SamLerner
- Status changed to Needs review
about 1 year ago 6:31pm 8 November 2023 - 🇺🇸United States SamLerner
Created an MR with the change to the dropdown, and a test to verify that the options are being sorted alphabetically. Hiding the patch file.
- Status changed to Needs work
about 1 year ago 7:39pm 8 November 2023 - 🇺🇸United States smustgrave
Ran the test-only feature in gitlab but the test did not fail. See https://git.drupalcode.org/issue/drupal-3399152/-/jobs/296610 so leaving that tag.
Also seems some existing tests have failed.
- 🇺🇸United States SamLerner
There was another functional test that was checking config name labels, and it needed the id/label reversed. Updated that test and pushed up the changes.
- Status changed to Needs review
about 1 year ago 9:50pm 8 November 2023 - Status changed to Needs work
about 1 year ago 4:38pm 9 November 2023 - 🇺🇸United States smustgrave
Test-only feature is failed.
But there is an open thread from @zniki.ru
- 🇺🇸United States SamLerner
I figured out the test block creation part by using
BlockContentSaveTest::createBlockContent()
as an example. Once I then figured out I needed to use$this->drupalPlaceBlock
inside mysetUp()
method, I was good to go. - Status changed to Needs review
about 1 year ago 8:58pm 13 November 2023 - Status changed to Needs work
about 1 year ago 4:53am 14 November 2023 - 🇷🇺Russia zniki.ru
@SamLerner thanks for updating the test scenario. MR looks good, I add some comments, please check and provide feedback.
- First commit to issue fork.
- Status changed to Needs review
about 1 year ago 4:42pm 15 November 2023 - Status changed to RTBC
about 1 year ago 1:06am 16 November 2023 - Status changed to Needs work
about 1 year ago 3:53pm 16 November 2023 - 🇺🇸United States xjm
I'm not totally sure about this change, so tagging for subsystem maintainer review. Additionally, since this is intended as a usability improvement, it should have embedded before and after screenshots in the issue summary.
Posted a few points on the MR as well. Thanks!
- Status changed to Needs review
about 1 year ago 4:43pm 16 November 2023 - 🇺🇸United States SamLerner
Made all the code updates and attached before/after screenshots.
- Status changed to RTBC
about 1 year ago 11:04am 1 December 2023 - 🇮🇳India Nitin shrivastava
@SamLerner MR#19 has been successfully applied, and now the dropdown will open in the 'config export' based on the machine name.
Before Patch
After Patch
- Status changed to Needs review
about 1 year ago 8:02pm 8 December 2023 - 🇺🇸United States xjm
The issue still needs subsystem maintainer signoff for the user expectations of this developer-facing form. @alexpott or @tim.plunkett are maintainers of relevant related subsystems.
- 🇮🇳India dishakatariya
Hi, Verified and tested #20 by taking pull from the latest branch on 11.x version. The changes were made are looking fine to me.
Followed the below steps:
1. Log in and go to /admin/config/development/configuration/single/export
2. Under Configuration type select Block.
3. Open the Configuration name dropdown
4. See the order is based on label, not machine name.
Attaching screenshot for reference.
Thanks - 🇬🇧United Kingdom alexpott 🇪🇺🌍
This seems like a better way of presenting this information. Nice one.
- 🇺🇸United States SamLerner
Thanks! I find it extremely useful because when I'm going to export single configs, I usually know the machine name, as that's what's displayed on the Config Synchronization page at
/admin/config/development/configuration
. Trying to sort through hundreds of configs by was pretty time-consuming. - Status changed to RTBC
about 1 year ago 4:25pm 10 January 2024 - 🇺🇸United States smustgrave
Thanks @alexpott!
Removing screenshots tag as they appear in the issue summary.
Confirmed applying the MR I'm seeing the configuration sorted by machine name.
- Status changed to Fixed
about 1 year ago 8:38am 11 January 2024 -
alexpott →
committed 4b3313c3 on 11.x
Issue #3399152 by SamLerner, smustgrave, sourabhjain, DishaKatariya,...
-
alexpott →
committed 4b3313c3 on 11.x
Automatically closed - issue fixed for 2 weeks with no activity.