- Issue created by @quietone
- 🇳🇿New Zealand quietone
Removing CKEditor becuase that is being done in 📌 [upstream] Update CKEditor 5 to 40.0.0 Needs review
- 🇬🇧United Kingdom longwave UK
We can update
stylelint-config-standard
, it's only a set of coding standards and they almost only ever release new majors when they change a standard (which often doesn't affect us anyway).Will spin off some child issues to break this up a bit.
- 🇬🇧United Kingdom longwave UK
Upgrading everything resulted in a lot of errors on
yarn build
:TypeError [ERR_INVALID_ARG_TYPE]: The "data" argument must be of type string or an instance of Buffer, TypedArray, or DataView. Received an instance of Promise
- 🇬🇧United Kingdom longwave UK
Keeping this open for a final round before 10.2.0 but at the time of writing we are pretty close to done:
$ yarn outdated Package Current Wanted Latest Package Type URL eslint-formatter-gitlab 5.0.0 5.1.0 5.1.0 devDependencies https://gitlab.com/remcohaszing/eslint-formatter-gitlab#readme glob 8.1.0 8.1.0 10.3.10 devDependencies https://github.com/isaacs/node-glob#readme loadjs 4.2.0 4.2.0 4.3.0-rc1 devDependencies https://github.com/muicss/loadjs nightwatch 2.4.2 2.4.2 3.3.0 devDependencies https://nightwatchjs.org shepherd.js 10.0.1 10.0.1 11.2.0 devDependencies https://shepherdjs.dev
- 🇳🇱Netherlands spokje
Updated IS with the latest state of affairs, also document the non-updatables with some explanation to help out with future "Update JavaScript dependencies for X.Y"
- 🇫🇮Finland lauriii Finland
What's the plan regarding updating Shepherd.js? Are we planning on running unsupported version of the library until 2026?
- 🇳🇱Netherlands spokje
What's the plan regarding updating Shepherd.js?
Interesting question, I assumed we can only bump major versions in a major release, so that would be 11.0.0.
https://www.drupal.org/about/core/policies/core-dependency-policies/depe... → states:
Major-version dependency updates are only done in major releases, unless they are required for a security update or critical bug.
.
But looking at the top paragraph of that link, that might only apply composer dependencies?
Since Drupal's Composer dependencies are packaged in Drupal tarballs, we are careful about updating Composer dependencies
- 🇬🇧United Kingdom longwave UK
The breaking change in Shepherd 11 was replacing popperJS with Floating UI. The problem is that if anyone was customising Tour module then upgrading this could well break their site, as I don't think there is a BC layer.
See #3323834: (Try to) update Sheperd.js to latest major version → where we started looking at this for 10.0 but we stalled and ran out of time.
- 🇳🇱Netherlands spokje
Updated IS after 📌 Update JavaScript dependencies for 10.2.0-RC Fixed landed.
- 🇳🇱Netherlands spokje
Updated IS to explain why
shepherd.js
isn't one of the easiest updates. - 🇬🇧United Kingdom catch
For shepherd.js we should go ahead with 📌 [11.x] [Meta] Tasks to remove Tour Postponed . A contrib tour could add a new major branch with the dependency switch once that's done - in some ways easier than doing it in core.
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
FYI: I learned 51 minutes ago that the CKEditor 5 team is planning a new
40.2.0
release next week. Did everything I could to prep for that: 📌 Update CKEditor 5 to 40.2.0 RTBC . I'll leave it to release managers to decide whether it's worth including in10.2.0
(or potentially tagging a second RC). - Status changed to Fixed
12 months ago 4:23pm 13 December 2023 Automatically closed - issue fixed for 2 weeks with no activity.