Update CKEditor 5 to 40.2.0

This will fix

• 🐛 [upstream] Add style to anchor leads to unusable behavior Postponed
• 🐛 [upstream] CKEditor 5 source code editor breaks with a Active

… but it currently results in ImageUrlTest failing, due to a BC break. See #3379104-29: Add a "CKEditor 5 nightly" GitLab CI job → . The CKEditor 5 team is aware and is investigating.

This can be worked on now and hopefully we can land it in 10.2.0: https://github.com/ckeditor/ckeditor5/releases/tag/v40.2.0

Thanks, @longwave! This should result in the same test failures I previously reported in #2. @lauriii told me he'd take a look 😊🥳 (he knows our DrupalImage plugin best).

As expected, needs work for fails in ImageUrlTest.

Tests are passing. I think we could potentially get rid of the DrupalInsertImage since it isn't doing anything at the moment. This could be disruptive because we need to update existing config, but there could be also code referring to the toolbar button, e.g. other plugins could depend on it with a condition. I don't think we should block the update with that.

The changes look solid. Thank you so much, @lauriii! 🙏

Two observations:

1. It seems that in this case they could and should have done a bit more work to remove the need for their downstream integrators to have to change code. Hopefully this will be better in the next release.
2. It'd be good if we can document the rationale for keeping DrupalInsertImage around as an empty shell right in the code that is being modified in drupalinsertimage.js. (I was going to say: let's mark it for removal in Drupal 11, but that will then still be a contrib ecosystem disruption then that we can avoid. The cost of keeping this around is negligible. And … who knows what other upstream breakages will happen in the future, and this would give us one more code execution point to insert work-arounds? 🙈)

Perfect! 😊🙏

Committed/pushed to 11.x and 10.2.x, thanks! Nice to get this one in. Do we need a follow-up to discuss DrupalInsertImage more?

I've updated the release notes for the version change.

Do we need a follow-up to discuss DrupalInsertImage more?

I don't think so. But I defer to @lauriii.

I don't think we need a follow-up. We could probably remove it but at the same time it could be helpful to have the plugin and the custom insert button already available in case that CKEditor team decides to make more BC breaking changes to their image insert button.

Automatically closed - issue fixed for 2 weeks with no activity.