Update CKEditor 5 to 40.1.0

Getting ahead of this at #3379104-15: Add a "CKEditor 5 nightly" GitLab CI job → .

Per https://git.drupalcode.org/issue/drupal-3379104/-/pipelines/47256/test_r..., looks like this likely will cause one test to fail:

Drupal\Tests\ckeditor5\FunctionalJavascript\ImageUrlTest::testImageUrlWidget
Failed asserting that a NULL is not empty.

/builds/issue/drupal-3379104/vendor/phpunit/phpunit/src/Framework/Constraint/Constraint.php:121
/builds/issue/drupal-3379104/vendor/phpunit/phpunit/src/Framework/Constraint/Constraint.php:55
/builds/issue/drupal-3379104/core/modules/ckeditor5/tests/src/FunctionalJavascript/ImageUrlTest.php:112
/builds/issue/drupal-3379104/vendor/phpunit/phpunit/src/Framework/TestResult.php:728

Per https://github.com/ckeditor/ckeditor5/issues/14724, this seems to be the most likely cause:

image: By default, images are inserted as block images (not inline). To switch to the previous behavior (determining image type by insertion context), set the editor config image.insert.type to "auto".

Thanks @Spokje!

Fixed the sole test failure by opting in to the old behavior per #4.

Unsure if we should

switch to the previous behavior

or adapt our test to the new way.

Leaving this for the professionals...

CROSSPOST-EDIT: Apparently the first is chosen as the way to go by the professionals (and apparently self RTBC-ing as well)

Committed and pushed 54862ffce4 to 11.x and aa810af52e to 10.2.x. Thanks!

(and apparently self RTBC-ing is also the way of the pros)

You did 99% of the work :)

All I did was opt in to the flag that keeps us on the same behavior that Drupal has had for the past several years when using CKEditor 5, which is by definition the safest choice.

Not doing that would have required test changes and additions, and would've risked breaking sites.

That's why I self-RTBC'd. I hope you agree now it was reasonable in this particular case 🙏

Automatically closed - issue fixed for 2 weeks with no activity.