Add validation constraints to field.settings

I took this one from DrupalCon Lille Contribution day

This is a good improvement over the current state, and it being not null is correct, but I think we should add a minimum value as well?

Do think a min makes sense. Can't purge -10 files right?

Let's postpone this on 📌 Add Missing Symfony Validators to Drupal Constraint Validator Needs work , that introduces a GreaterThan

Actually, it looks like the range constraint can also do this, unpostponing this issue.

svendecabooter → changed the visibility of the branch 11.x to hidden.

svendecabooter → changed the visibility of the branch 11.x to active.

There were some problems with the 11.x branch on this issue's repo.
After discussion with borisson_ I added a new merge request to the other branch that existed on this issue.
The change by hdnag is also added to this branch now.

svendecabooter → changed the visibility of the branch 11.x to hidden.

Adding tag.

Looks great

Agreed with RTBC 😊

I don't think zero is really a valid size here, we would never purge anything and never warn anyone that nothing was purged. I realise that's the status quo that you can set it to zero, but feels like codifying the existing bug further.

If we think it's a feature to be able to set this to zero (to prevent purging in order to debug), then there should probably be a hook_requirements() warning when it's set to zero to remind people to enable it again. If that's the case then fine with opening a follow-up for it. Or making the minimum range 1.

I realise that's the status quo that you can set it to zero, but feels like codifying the existing bug further.

D'oh, I should've spotted this 😬 Setting this to zero means nothing would ever happen 😅

Disallowing a previously allowed value in principle means we need to provide an update path, to reset it to the default. But in this case, that seems such an extremely unlikely thing … that I wonder if we can get away with just changing the minimum to 1? 🤔 (Because 0 would not have worked anyway, so nobody would ever have had a need to set it to that?)

I guess the only question is - does it need to be left open to prevent field purging? I could see someone maybe using that in a situation like 🐛 Enforced dependency bundles are deleted without validation when modules are uninstalled Active but also you would only find out about that issue either before or after that would ever be useful. So I don't really think it is a valid use case and we should set the minimum to 1.

👍 Done. Re-RTBC'ing since it's a trivial change.

Committed 2256cd2 and pushed to 11.x. Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.