Fix non-english words in tests

jamo was missing from issue summary.

Text changes seem good though.

Unrelated failure on the MR after a rebase

    Drupal\Tests\media\FunctionalJavascript\MediaSourceOEmbedVideoTest::testMediaOEmbedVideoSource
    WebDriver\Exception\JavaScriptError: javascript error: Cannot read
    properties of null (reading 'getAttribute')
      (Session info: headless chrome=106.0.5249.103)
      (Driver info: chromedriver=106.0.5249.61
    (511755355844955cd3e264779baf0dd38212a4d0-refs/branch-heads/5249@{#569}),platform=Linux
    5.4.241-150.347.amzn2.x86_64 x86_64)

Do we want to replace "yarhar" with "yahoo" which appears to be in the dictionary?

Not sure. But since those are all about pirate speak I have removed them from this issue and I'll make an issue just for those.

Reroll seems good. Appears to still have one change for yarhar but seems small so think it's fine.

Cucurbitaceae, while from Latin, is a legit English word, although it should be capitalized as a botanical family name: https://en.wikipedia.org/wiki/Cucurbitaceae I feel like I might be responsible for that one...

Saving issue credits.

So I am confused by the scope of this issue. See above comments on the MR.

Aside from the out-of-scope stuff, this issue has two types of changes: placeholders, words from other languages, or words with diacriticals being ignored, and words from other languages being replaced with English.

I was half joking about the imperialism aspect earlier, but it does seem anglocentric to not allow translatable words in test fixtures. I'm proud of the multilingual content in tests and it reflects past contribution events and so on. It's not like pop culture references where it might be problematic for people from different backgrounds; it's instead highlighting one of Drupal's strengths: our multilingual community. So I am on the fence about whether to replace those words or to ignore them.

The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

@xjm, thanks for the review of this and the other spelling issues.

I do understand about being on the fence for non English words and I was reluctant to remove Te Reo from various migration tests. See 📌 Fix spelling for 29 migrate translation related words Fixed . But it does not matter for migration tests that the text was English or another language because they are not testing the translation system itself. And I recall from conversation (can't find documentation) that the non English in the dictionary should be reserved for words that are used in the testing of the translation system.

As for scope, I can only say I find it difficult for the spelling issues. Grep can only do so much to find a sensible set of changes.

Broadly speaking, it would help if the community would decide before hand what words are not to be changed (Drupalisms, non English words for translation, words that are culturally significant for the Drupal community etc) before making a Meta to fix misspellings. There is no guidance on this until you make a patch or MR and get feedback. This is why I support having a separate Drupal dictionary, where we can have a place for words important to our community separate from the ones we really need to fix. 📌 Add a dictionary for Drupal-specific words RTBC

The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

Another rebase and rebuild of dictionary.

Reroll seesm to be good.

Went through the MR, RTBC+1 it's not in my scope so leaving for someone else to commit.

It's fun that I can kinda guess who worked on which part of the code based on the language used in tests :p

This needs rebasing against 11.x due to other changes in dictionary.txt.

Resolved conflicts and rebased done on ht MR, thanks!

Reroll seems fine.

Committed and pushed 67dbfb98ae to 11.x and fce7fbec5c to 10.2.x. Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.

quietone → closed merge request !5006