[D10.1] - Plan WxT 5.1.0 release

One of my projects has a requirement to be on 10.1.x/PHP8.2, so interested in getting this going sometime soon!

Thanks, I've been using WxT v5.0.0 on PHP 8.2 for a company project, I've seen a few warnings here and there, I might submit extra issues here.

I haven't actually started this yet but I'm imagining that the actual upgrade to D10.1.5+ will be quite easy.

Once I get a chance, I'll push a patch, unless someone else does first.

There's reasons to upgrade to PHP 8.2.x and D10.1.5+ sooner than later.

I'm doing some tests with the "Upgrade Status" module, I'll submit a patch sometime this weekend.

Sorry it was an impulse, I have to focus on 10.0.11 still and wxt 5.0.x

I see some deprecated code (warnings) at modules/custom/wxt_core/tests/context/EntityContext.behat.inc:

Attached a patch to fix this, tested locally on a WxT 5.0.1 instance (DDEV - PHP 8.1)

Sorry, patch provided !

That patch looks good except I'd use accessCheck(FALSE) instead of TRUE to simplify and lower the risk of the change

accessCheck(TRUE) could fail if the test code doesn't have the expected permissions.

with that said, it might be fine either way.

Also, accessCheck(TRUE) invokes db queries to check for permissions, so depending on the use case it could increase expense of the operation and not really provide meaningful security (depending on the context).

Thanks for your input @joseph.olstad , you have a valid point there, attached the patch with the changes.

For some reason I was still seeing the deprecation warning at EntityContext.behat.inc after applying the patch, this new patch fixes this, sorry for the inconvenience.

Appreciate the help as always! I have merged this into a new 5.1.x branch.

Please find below a list if changes in the 5.1.x branch:

• Update core to 10.1.6
• Re-roll core patch #850600 ✨ PostgreSQL driver doesn't support SSL option Needs work for 10.1.x, update patch in WxT
• Remove core patch that was rolled into 10.1.x - #3017710 📌 Drupal\Core\TypedData\TypedData::getPropertyPath() is slow Fixed
• Add config rewrite to enable theme_blazy() to remove error on Status page
• Changes from this ticket to add accessCheck() to entity queries

Remaining tasks for 10.1.x upgrade:

• Fix SVG icon in #3400930 →
• Test new build and fix issues as required

I tried out 5.1.x with D10.1.6 , the upgrade worked for me.

Any timeline on a tag for 5.1.0 ?

D10.0.11 is EOL in a few weeks from now, Dec 11

it would be nice to have an rc1 tag for 5.1.0
example 5.1.0-rc1

I've been kicking it for a couple hours now, looks great!

Great work on this BTW, I wasn't expecting it, welcome surprise! Even better is that it was an easy upgrade so far, spun it up in no time , upgraded a fairly complex stack from 10.0.11 /wxt 5.0.x to 10.1.6 / wxt 5.1.x quickly . Took about an hour of fiddling with composer and a couple minor issues fixed in about 20 minutes, then testing for 2 hours, seems quick, seems snappy, I see subtle UI improvements in the admin side, so far so good!

Might actually have to go with this!

it would help to have an rc1 to justify the action.

Hi @smulvih2 and @sylus, I noticed this marked as "Fixed", however I didn't see a 5.1.0-rc1 tag yet?
I also checked the 5.1.x branch, it may be missing some recent work done to 5.0.x.

maybe wait for the security window on wednesday to pass and then tag something wednesday evening or thursday, that'd be great, maybe merge some stuff into 5.1.x so I can give it another whirl.

@joseph, I merged 5.0.x into 5.1.x and pushed to GitHub for testing - https://github.com/drupalwxt/wxt/tree/5.1.x

I ran a fresh install and works for me. Please test this and report back. Thanks!

@smulvih2 , I normally test from package manager which uses the https://git.drupalcode.org/ repositories

Please push your 5.1.x changes and other repo changes to the https://git.drupalcode.org/ upstream so that the d.o package manager gets updated.

Pushed changes for 5.1.x to drupalcode repo.

Him, maybe it's still in transmission, I just checked again, lol

@smulvih2
I upgraded, it works great!
Please tag 5.1.0-rc1 or 5.1.0

@sylus, can you please provide an ETA on the tagged release?

I'm wondering maybe I should just go ahead with building without a tag. I've tested it already, it would be good to have a tag as a point of reference. However I guess I can put the latest commit hash into the require section and call it good enough.

I'm hoping for two tagged releases.
5.0.2 and 5.1.0-rc1

Updating issue summary

Thanks @sylus

https://www.drupal.org/project/wxt/releases/5.1.0 →

Automatically closed - issue fixed for 2 weeks with no activity.