- πΊπΈUnited States smustgrave
Triggering for 10.1 but was this waiting on anything else? Reading the comments and seemed to leave off on the test failures. Can wait to see what 10.1 does.
- Status changed to RTBC
almost 2 years ago 7:53pm 4 February 2023 - Status changed to Fixed
almost 2 years ago 1:29pm 5 February 2023 -
alexpott β
committed 91e19e5c on 10.1.x
Issue #3017710 by ndobromirov, joseph.olstad, Wim Leers, alexpott,...
-
alexpott β
committed 91e19e5c on 10.1.x
- πΊπΈUnited States phenaproxima Massachusetts
One small thing that should maybe be done in as a small follow-up patch (probably don't even need a separate issue for this): there really should be a comment there explaining why we're using the constructs we're using, and that it was specifically done for performance reasons. Otherwise we risk regressing it in the future, since we're not (AFAIK) doing regular profiling of core.
Automatically closed - issue fixed for 2 weeks with no activity.
- Status changed to Fixed
almost 2 years ago 7:12am 23 February 2023 - π³πΏNew Zealand quietone
Followup made, π Add comments explaining performance improvement in TypedData Fixed