Create new Badge component for recipe

Maybe it is good play to use render of component
https://www.drupal.org/docs/develop/theming-drupal/using-single-director... →

Believe this needs manual rebasing. MR is not mergable and rebase button not there.

I like the idea @finnsky had in #4 of using array. Don't think we have an example of that yet.

Because those 4 are Drupal fields I would say the options are the following:

Option 1:

A formatter to be able to render the component as suggested in #4, which I think is out of the scope of this patch.

Option 2:

Use hook_theme_suggestions_HOOK to make all those fields to use a single template as suggested by Mark, the problem with this is how to set the icons properly, maybe by getting the field_name on each and assigning the icon accordingly.

@jidrone gonna check second option.
At least i have no example of managing SDC render arrays on theme level.

CC failure.

IS may need to be updated if this is going to try a different approach. Still think we need an example of a render array for sdc but optionB is also an example we don't currently have.

I think can be reviewed as is. We have new component and new SDC usage example via template suggestion.

So if several fields use one component it may have twig template suggestion like:

`field__COMPONENT_NAME__component.twig`

OR

`field__COMPONENT_NAME__sdc.twig`

AND

be stored in `/templates/sdc/` directory of theme.

At least until SDC cannot generate formatters from components ;)

From a reviewer/committer standpoint the clearer an issue summary the quicker it moves along.

Updated IS myself.

Took me longer to get back to this ticket then I thought.

I applied MR 4896 and the badges remained the same.

Before

After

Think this is a good example to add.

I left some suggestions.

@e0ipso

I just rebased. could you please take one more look on it. Your proposal in fact was in initial plan ;)

I think the best solution is 4 templates. Even if it's more verbose, IMO it is way more predictable.

I have the impression that we no longer benefit from SDC's main feature: everything is in the single directory instead we are back to fishing in preprocess functions. And while I think that will be unavoidable/adviceable in some situations, I think this is not one of those.

How do others feel about this?

Setting to Needs Review for discussion. Sorry for dragging this, we are colectivelly figuring this out.

@e0ipso
I totally agree with you! This Umami is example theme for beginners. everything should be supersimple and predictable ;)
Let's revert with 4 twigs

I can verify that I haven't observed any visual alterations following the most recent modifications related to four distinct templates.

@snig did you try at differnt viewport sizes as well?

This looks good to me from a static review standpoint. As usual I cannot sign off any of the CSS, but if @snig confirms there are no visual regressions in any viewport size I am good with it.

@e0ipso Looks good for all the viewpoints. Proof attached.

Posted one minor comment on the MR, otherwise looks good 👍

For what it's worth I thought the template suggestion was a good example of another way SDC could be leveraged vs needing 4 near identical templates. But not dying on that hill haha.

Seems @laurii's feedback has been addressed

lauriii → closed merge request !4896

It would be nice if there was a way to load the SDC for all of those templates in an easier way.. Anyway, this is good enough for now and we can look for better ways to do that in a follow-up issue.

Committed 9efe78f and pushed to 11.x. Also cherry-picked to 10.2.x. Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.