Provide a trait to create file upload validators from file field settings

Issue created by @kim.pepper
Merge request !4866Issue #3389447: Provide a trait to create file upload validators from settings → (Closed) created by kim.pepper
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update 9 months ago
30,158 pass, 5 fail
Status changed to Needs review 9 months ago6:34am 25 September 2023
Comment 9 months ago →
🇦🇺Australia kim.pepper 🏄‍♂️🇦🇺Sydney, Australia
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update 9 months ago
30,206 pass
Status changed to Needs work 9 months ago6:24pm 25 September 2023
Comment 9 months ago →
🇺🇸United States smustgrave
Change looks good. Can we get a CR to announce the new trait?
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update 9 months ago
30,208 pass
Status changed to Needs review 9 months ago10:27pm 25 September 2023
Comment 9 months ago →
🇦🇺Australia kim.pepper 🏄‍♂️🇦🇺Sydney, Australia
Had a thought that we may need to add a trait for getImageUploadValidators() as code is duplicated between ImageWidget and CKEditor5ImageController. Created 📌 Provide a trait to create image upload validators from settings Active for that.

Renamed the trait method to \Drupal\file\Validation\FileValidatorSettingsTrait::getFileUploadValidators() for clarity.

Added a CR.
Comment 9 months ago →
🇦🇺Australia kim.pepper 🏄‍♂️🇦🇺Sydney, Australia
Comment 9 months ago →
🇦🇺Australia kim.pepper 🏄‍♂️🇦🇺Sydney, Australia
Blocking a critical 📌 [PP-4] Unify file upload logic of REST and JSON:API Postponed therefore this is also critical.
Status changed to RTBC 9 months ago1:31pm 26 September 2023
Comment 9 months ago →
🇺🇸United States smustgrave
Trait short and sweet haha. Looks good though.
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update 9 months ago
30,362 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update 9 months ago
30,360 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
26:33
22:09
Running
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update 9 months ago
30,371 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update 9 months ago
30,377 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update 9 months ago
30,382 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update 9 months ago
30,384 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update 9 months ago
30,393 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update 8 months ago
30,397 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update 8 months ago
30,411 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update 8 months ago
30,416 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update 8 months ago
30,420 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update 8 months ago
30,426 pass
Comment 8 months ago →
🇳🇿New Zealand quietone New Zealand
I'm triaging RTBC issues → . I read the IS and the comments. I didn't find any unanswered questions or other work to do.

Leaving at RTBC.
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update 8 months ago
30,434 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update 8 months ago
30,438 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update 8 months ago
30,464 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update 8 months ago
30,481 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update 8 months ago
Build Successful
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update 8 months ago
30,486 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update 8 months ago
30,486 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
56:34
34:04
Running
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update 8 months ago
30,516 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update 8 months ago
30,519 pass
Comment 7 months ago →
🇦🇺Australia kim.pepper 🏄‍♂️🇦🇺Sydney, Australia
Status changed to Needs review 7 months ago3:52am 13 November 2023
Comment 7 months ago →
🇦🇺Australia larowlan 🇦🇺🏝.au GMT+10
Let a comment on the MR clarify

+1 for the new title
Comment 7 months ago →
🇦🇺Australia larowlan 🇦🇺🏝.au GMT+10
Back to RTBC after reply to my question. No code change so just reinstating #8
Status changed to RTBC 7 months ago4:37am 13 November 2023

larowlan → committed 82c59f84 on 11.x

Issue #3389447 by kim.pepper, smustgrave, quietone: Provide a trait to...

Status changed to Fixed 7 months ago4:37am 13 November 2023
Comment 7 months ago →
🇦🇺Australia larowlan 🇦🇺🏝.au GMT+10
Committed and pushed to 11.x
Published the change record.
Comment 7 months ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.
Comment 4 months ago →
System Message
kim.pepper → closed merge request !4866

Provide a trait to create file upload validators from file field settings

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Merge Requests

!4866Provide a trait to create file upload validators from file field settings
Closed

Comments & Activities

Provide a trait to create file upload validators from file field settings

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Merge Requests

!4866Provide a trait to create file upload validators from file field settingsClosed

Comments & Activities

!4866Provide a trait to create file upload validators from file field settings
Closed