- Issue created by @kim.pepper
- Merge request !4866Issue #3389447: Provide a trait to create file upload validators from settings → (Closed) created by kim.pepper
- last update
9 months ago 30,158 pass, 5 fail - Status changed to Needs review
9 months ago 6:34am 25 September 2023 - last update
9 months ago 30,206 pass - Status changed to Needs work
9 months ago 6:24pm 25 September 2023 - 🇺🇸United States smustgrave
Change looks good. Can we get a CR to announce the new trait?
- last update
9 months ago 30,208 pass - Status changed to Needs review
9 months ago 10:27pm 25 September 2023 - 🇦🇺Australia kim.pepper 🏄♂️🇦🇺Sydney, Australia
Had a thought that we may need to add a trait for getImageUploadValidators() as code is duplicated between ImageWidget and CKEditor5ImageController. Created 📌 Provide a trait to create image upload validators from settings Active for that.
Renamed the trait method to
\Drupal\file\Validation\FileValidatorSettingsTrait::getFileUploadValidators()
for clarity.Added a CR.
- 🇦🇺Australia kim.pepper 🏄♂️🇦🇺Sydney, Australia
Blocking a critical 📌 [PP-4] Unify file upload logic of REST and JSON:API Postponed therefore this is also critical.
- Status changed to RTBC
9 months ago 1:31pm 26 September 2023 - last update
9 months ago 30,362 pass - last update
9 months ago 30,360 pass 4:00 59:36 Running- last update
9 months ago 30,371 pass - last update
8 months ago 30,377 pass - last update
8 months ago 30,382 pass - last update
8 months ago 30,384 pass - last update
8 months ago 30,393 pass - last update
8 months ago 30,397 pass - last update
8 months ago 30,411 pass - last update
8 months ago 30,416 pass - last update
8 months ago 30,420 pass - last update
8 months ago 30,426 pass - 🇳🇿New Zealand quietone New Zealand
I'm triaging RTBC issues → . I read the IS and the comments. I didn't find any unanswered questions or other work to do.
Leaving at RTBC.
- last update
8 months ago 30,434 pass - last update
8 months ago 30,438 pass - last update
8 months ago 30,464 pass - last update
8 months ago 30,481 pass - last update
8 months ago Build Successful - last update
8 months ago 30,486 pass - last update
7 months ago 30,486 pass 34:01 11:31 Running- last update
7 months ago 30,516 pass - last update
7 months ago 30,519 pass - Status changed to Needs review
7 months ago 3:52am 13 November 2023 - 🇦🇺Australia larowlan 🇦🇺🏝.au GMT+10
Let a comment on the MR clarify
+1 for the new title
- Status changed to RTBC
7 months ago 4:37am 13 November 2023 -
larowlan →
committed 82c59f84 on 11.x
Issue #3389447 by kim.pepper, smustgrave, quietone: Provide a trait to...
-
larowlan →
committed 82c59f84 on 11.x
- Status changed to Fixed
7 months ago 4:37am 13 November 2023 - 🇦🇺Australia larowlan 🇦🇺🏝.au GMT+10
Committed and pushed to 11.x
Published the change record. Automatically closed - issue fixed for 2 weeks with no activity.