Fix return type in \Drupal\Core\Database\Query\Merge::__toString

quietone → credited amateescu → .

quietone → credited daffie → .

Came across 🐛 Drupal\Core\Database\Query\Query::__toString() must return a string value Needs work today which is fixing this as part of the problem in that Issue Summary. That was RTBC and pushed back for a test in a different file. git status have moved the changes relevant to this issue here and adding credit.

see comments inline

Looks good to me.

I'm not sure this is the correct fix. Atm if this is called you would get an error - see https://3v4l.org/JKklI

Can we put a throw \BadMethodCallException in here instead.

Forgot about this one. Rebase and change to throwing an exception.

Appears feedback has been addressed

Test coverage added for the exception in #12 also appears to be added.

Added a comment to the MR.

Maybe add some documentation is sufficient.

Think adding the additional sentence addresses the feedback.

I think we should fix \Drupal\core_fake\Driver\Database\CoreFakeWithAllCustomClasses\Upsert::__toString() here - it should throw an exception. And I also think we should change \Drupal\Tests\Core\Database\Stub\StubUpsert::__toString to throwing an exception too. That's the only place I can find where we return an empty string here - it's it just test code for stub for test purposes so does not count.

Fix the items in the MR. Back to NR.

Feedback for a return exception from #18 appears to be addressed.

Committed 5f1bd5f and pushed to 11.x. Thanks!

quietone → closed merge request !5135

quietone → credited mstrelan → .

Closed 🐛 Drupal\Core\Database\Query\Query::__toString() must return a string value Needs work as a duplicate and moving credit.

Automatically closed - issue fixed for 2 weeks with no activity.