ToolbarClaroOverridesTest fails intermittently

Ran in to this again at https://git.drupalcode.org/issue/drupal-3316317/-/jobs/4767068, The line number is now 143, not 141, but otherwise the same.

This one is unusual because it's not a javascript test, so it's not a matter of waiting until the class is applied, it should have been there from the start. I've attached the browser output from a fail and a pass, and sure enough the claro- classes don't appear in the output of the failed test. The only other differences are the assets query string and the user permissions hash.

I looked at where the claro-toolbar and claro-toolbar-menu classes come from and they are added directly in twig files in the claro theme. These files are overrides of twig files in the toolbar module, with no other changes, so this points to an issue with theme suggestions not being correctly applied. The test is loading the page with initial config, then setting config via API, then loading the same page again. I'm thinking we need to manually clear a cache, or perhaps wait for a cache to finish writing before loading the page.

mstrelan → changed the visibility of the branch 3387939-repeat to hidden.

mstrelan → changed the visibility of the branch 3387939-repeat-fix to hidden.

Using WaitTerminateTestTrait fixes this. Updated the IS with links to test runs.

Ran into this one on 📌 Consider using the administration theme when editing or creating content by default Active which was really confusing as it seemed like it was caused by the changes, spent quite a while trying to figure that out so this would be great to fix permanently.

The explanation in #4 and IS lines up with the solution and the repeated branches demonstrate this fixes the random fails.

larowlan → closed merge request !11612

Committed to 11.x - thanks!

Automatically closed - issue fixed for 2 weeks with no activity.

mstrelan → closed merge request !11607

mstrelan → closed merge request !11610